Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: EligibilityType model fields for expiration - validation on model #1957

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

angela-tran
Copy link
Member

Closes #1938

This PR adds fields to the EligibilityType model that will be needed to support expiration of benefits.

The model implements the validation specified on #1938.

@angela-tran angela-tran self-assigned this Mar 14, 2024
@angela-tran angela-tran requested a review from a team as a code owner March 14, 2024 22:37
@github-actions github-actions bot added migrations [auto] Review for potential model changes/needed data migrations updates back-end Django views, sessions, middleware, models, migrations etc. tests Related to automated testing (unit, UI, integration, etc.) deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Mar 14, 2024
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  benefits/core
  models.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I was able to trigger the custom validation in my local Admin:

image

@angela-tran angela-tran merged commit ab3dbc1 into dev Mar 18, 2024
18 checks passed
@angela-tran angela-tran deleted the feat/eligibilitytype-expiration-fields branch March 18, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev migrations [auto] Review for potential model changes/needed data migrations updates tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance EligibilityType model with expiration-related field(s)
2 participants