Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: EligibilityType model fields for expiration - validation on model #1957

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Feat: EligibilityType model fields for expiration - validation on model #1957

merged 4 commits into from
Mar 18, 2024

Commits on Mar 14, 2024

  1. feat(model): add expiration-related fields to EligibilityType 

    `supports_expiration` serves as a toggle for expiration functionality.
the other fields are for configuring the duration before expiration and
reenrollment.
    @angela-tran
    angela-tran committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    4fabc1d View commit details
    Browse the repository at this point in the history

  2. feat: validate EligibilityType expiration days and reenrollment days

    @angela-tran
    angela-tran committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    b3d71f6 View commit details
    Browse the repository at this point in the history

  3. test(model): supports_expiration being False results in valid object

    @angela-tran
    angela-tran committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    af0eb63 View commit details
    Browse the repository at this point in the history

  4. test(model): positive values are required if supporting expiration

    @angela-tran
    angela-tran committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    b109035 View commit details
    Browse the repository at this point in the history