-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: enrollments can expire #2165
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
I manually tested the expiration scenarios in benefits/benefits/enrollment/views.py Lines 117 to 155 in 2a80a60
|
Rebased on top of latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to test the different expiration scenarios for enrollments and they worked. Looking over the code, everything looked good too 👍
Closes #2062
This PR reverts "Revert "Feat: enrollments can expire (#1989)" (#2052)".
There were merge conflicts with various features and refactors that were done since #2052, and I think I resolved them all correctly. (Examples are system enrollment error logic and enrollment success template refactor.)