feat: Added Azure location to facts #3389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnsnyder
requested review from
a team and
m-horky
and removed request for
a team
Coverage (computed on Fedora latest) •
|
||||||||||||||||||||||||||||||||||||||||
|
BTW: documentation for Azure IMDS metadata is available here: https://learn.microsoft.com/en-us/azure/virtual-machines/instance-metadata-service?tabs=linux |
|
New code tested on Azure and it works. |
ptoscano
force-pushed
the
jhnidek/azure_region_fact
branch
from
1a0ea96 to
0849db3
Compare
* Card ID: CCT-384 * Add azure_location to facts, when available * TODO: update required version of metadata and get extended locatition fact
* Update the version of metadata we try to get from Azure IMDS server, because we need facts from new version of metadata and old version of metadata could be deprecated in the future
* Card ID: CCT-384
* Added new facts from Azure IMDS metadata available since
2021-03-01
* Metadata with given version provides extendedLocation.name
and extendedLocation.type
* Extendd unit tests to include new facts
ptoscano
force-pushed
the
jhnidek/azure_region_fact
branch
from
0849db3 to
0bba05e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version of metadata and old version of metadata could be deprecated in the future
extendedLocation.nameandextendedLocation.type