[1.29] feat: deprecate attach/auto-attach #3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DuckBoss
force-pushed
the
jajerome/deprecate-auto-attach
branch
3 times, most recently
from
b19f8dc to
38c92bc
Compare
Updated man-page to include deprecation notices to usage instructions of 'attach' and 'auto-attach' commands. Signed-off-by: Jason Jerome <[email protected]>
DuckBoss
force-pushed
the
jajerome/deprecate-auto-attach
branch
from
38c92bc to
5d880ca
Compare
jirihnidek
requested changes
Jun 10, 2024
|
|
||
| def _command_name(self): | ||
| return "attach" | ||
|
|
||
| def _primary(self): | ||
| return True | ||
| return False |
This patch adds a deprecation notice to the attach/auto-attach command descriptions. This patch also moves the attach command to the 'Other Modules' section in the sub-man help text from the 'Primary Modules' section. The attach command already displays an error message when attempting to attach subscriptions with an SCA registered system, so no changes are required to implement this. Signed-off-by: Jason Jerome <[email protected]>
This patch updates the '--auto-attach' and '--autosubscribe' options help text with a deprecation notice. Signed-off-by: Jason Jerome <[email protected]>
DuckBoss
force-pushed
the
jajerome/deprecate-auto-attach
branch
from
5d880ca to
f6e9a2c
Compare
jirihnidek
approved these changes
Jun 10, 2024
jirihnidek
merged commit e4bfa2e
into
candlepin:subscription-manager-1.29
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update aims to add deprecation notices to the attach/auto-attach commands.
Changes Made
attachandauto-attachmodule descriptions.--auto-attachand--autosubscriberegister options help text.attachmodule from the 'Primary Modules' section in the sub-man help text to 'Other Modules'.Resolves: CCT-401