Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [1.29] Remove command should not be primary command #3416

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

jirihnidek
Copy link
Contributor

@cnsnyder cnsnyder requested review from a team and DuckBoss and removed request for a team June 10, 2024 09:45
* Card ID: CCT-403
* There is no reason to keep this command as primary command
* Card ID: CCT-403
* Fix numbers of the list of commands
* Removed deprecated commands from the list of commands
* Add remove and redeem commands to the list of deprecated
  commands
@jirihnidek jirihnidek force-pushed the jhnidek/1.29_remove_cmd_tweaks branch from f982728 to 260376e Compare June 11, 2024 13:01
@jirihnidek jirihnidek marked this pull request as ready for review June 11, 2024 13:03
@cnsnyder cnsnyder requested a review from a team June 11, 2024 13:03
Copy link
Contributor

@DuckBoss DuckBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍

@DuckBoss DuckBoss merged commit 41055f2 into subscription-manager-1.29 Jun 12, 2024
5 checks passed
@jirihnidek jirihnidek deleted the jhnidek/1.29_remove_cmd_tweaks branch June 13, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants