Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [1.29] Remove command should not be primary command #3416

Merged
merged 2 commits into from
Jun 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 17 additions & 23 deletions man/subscription-manager.8
Original file line number Diff line number Diff line change
Expand Up @@ -77,62 +77,56 @@ must be passed as system arguments in a non-interactive session.
2. unregister

.IP
5. remove
3. release

.IP
6. release
4. import

.IP
7. import
5. list

.IP
8. redeem
6. refresh

.IP
9. list
7. environments

.IP
10. refresh
8. repos

.IP
11. environments
9. orgs

.IP
12. repos
10. plugins

.IP
13. orgs
11. identity

.IP
14. plugins
12. facts

.IP
15. identity
13. clean

.IP
16. facts
14. config

.IP
17. clean
15. version

.IP
18. config
16. status

.IP
19. version
17. syspurpose

.IP
20. status

.IP
21. syspurpose

.IP
22. repo-override
18. repo-override

.RE

Following commands were deprecated: addons, attach, auto-attach, role, service-level, subscribe, unsubscribe, usage, and activate
Following commands were deprecated: addons, attach, auto-attach, remove, redeem, role, service-level, subscribe, unsubscribe, usage, and activate

.SS COMMON OPTIONS
.TP
Expand Down
6 changes: 5 additions & 1 deletion src/subscription_manager/cli_command/remove.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,11 @@ def _command_name(self):
return "remove"

def _primary(self):
return True
"""
This command is deprecated and no-op. It used to be primary command, but
there is no reason to have keep this command as primary command anymore.
"""
return False

def _validate_options(self):
if self.options.serials:
Expand Down
Loading