Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: man page modifications after removal of deprecated commands #3447

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

DuckBoss
Copy link
Contributor

@DuckBoss DuckBoss commented Aug 16, 2024

I'm leaving this PR as a draft until the following PRs are merged:

This PR contains some redundant commits to visualize the final man page modifications after the above PRs are merged. I will rebase and squash this PR on top of the other man page changes, so there might not be much changes in this PR when all is said and done except some small modifications to language/wording.

Card ID: CCT-545

@DuckBoss DuckBoss force-pushed the jajerome/rhel10-man-page-depr branch from d66321c to 0f99876 Compare August 16, 2024 18:21
man/subscription-manager.8 Show resolved Hide resolved
man/subscription-manager.8 Outdated Show resolved Hide resolved
man/subscription-manager.8 Outdated Show resolved Hide resolved
@DuckBoss DuckBoss force-pushed the jajerome/rhel10-man-page-depr branch from 46df90c to 977e35f Compare September 2, 2024 04:29
man/subscription-manager.8 Outdated Show resolved Hide resolved
@DuckBoss DuckBoss force-pushed the jajerome/rhel10-man-page-depr branch 2 times, most recently from 1d01503 to cd51a18 Compare September 4, 2024 15:43
@DuckBoss DuckBoss changed the title chore: man page modifications after removal of deprecated commands docs: man page modifications after removal of deprecated commands Sep 4, 2024
@DuckBoss DuckBoss force-pushed the jajerome/rhel10-man-page-depr branch 2 times, most recently from 7a2707d to 56d30f9 Compare September 9, 2024 00:19
This patch removes remaining references to commands that were deprecated and removed.

 * Removed references to 'redeem' command
 * Removed references to 'attach' command
 * Fixed numbering for list of supported commands
 * Rephrased deprecated command section message
 * Update activation key messaging
 * Removed deprecated commands list
 * Adjusted wording slightly around attaching/auto-attaching subscriptions
 * Removed 'subscribe' from deprecated commands
 * Removed references to '--auto-attach/--servicelevel' register options

Card ID: CCT-545
@DuckBoss DuckBoss force-pushed the jajerome/rhel10-man-page-depr branch from 56d30f9 to 8b17341 Compare September 9, 2024 01:31
@DuckBoss DuckBoss marked this pull request as ready for review September 9, 2024 17:29
Copy link
Contributor

@ptoscano ptoscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update LGTM, thanks.

Sadly the man page is in dire need for a much thorough review... 😢

@ptoscano ptoscano merged commit 8af6106 into candlepin:main Sep 12, 2024
10 of 17 checks passed
@DuckBoss DuckBoss deleted the jajerome/rhel10-man-page-depr branch September 12, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants