feat: Eliminate command 'remove' from subscription-manager #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvlcek
changed the title
jvlcek
force-pushed
the
CCT-426_remove_remove
branch
from
75b23f3 to
069cc19
Compare
jirihnidek
reviewed
Aug 16, 2024
|
Please rebase and fix the conflicts due to the other removals, thanks! |
ptoscano
reviewed
Aug 28, 2024
... and in addition to that, please squash the commit fixing the changes to the man page together with the original commit |
ptoscano
reviewed
Aug 28, 2024
jvlcek
force-pushed
the
CCT-426_remove_remove
branch
2 times, most recently
from
8b6625d to
f8ce2a9
Compare
This PR eliminates the subscription-manager remove sub-command. fixes: https://issues.redhat.com/browse/CCT-426
jvlcek
force-pushed
the
CCT-426_remove_remove
branch
from
77353be to
027dd3d
Compare
|
I believe this is ready to merge now. @jirihnidek and @ptoscano please take a look. Thank you! Joe |
ptoscano
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR eliminates the subscription-manager remove sub-command.
fixes: https://issues.redhat.com/browse/CCT-426