Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update create instance details #260

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

anusha-c18
Copy link
Collaborator

  • update create instance details
  • targeted for 1.25 release

@anusha-c18 anusha-c18 requested a review from a team as a code owner January 9, 2025 12:22
@ajanon ajanon requested a review from keirthana January 10, 2025 09:34
@ajanon
Copy link
Contributor

ajanon commented Jan 10, 2025

Could you please target the next-release branch if you want it for 1.25? I'm not sure if we have this workflow documented. @keirthana Do we have it written somewhere?

@keirthana
Copy link
Collaborator

Could you please target the next-release branch if you want it for 1.25? I'm not sure if we have this workflow documented. @keirthana Do we have it written somewhere?

Yes, we have it in this spec: https://docs.google.com/document/d/1yXJvZLHqQJz6YpqD0HsLwOW8O-2ZCVbu4GKGxXRHefA/edit?tab=t.0

I will help Anusha target this for 1.25.

@anusha-c18 anusha-c18 changed the base branch from main to next-release January 13, 2025 11:59
@anusha-c18
Copy link
Collaborator Author

Changed the base branch @keirthana

@anusha-c18 anusha-c18 force-pushed the update-instance-create branch from 1441e92 to 38bb460 Compare January 13, 2025 12:31
Copy link
Collaborator

@morphis morphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keirthana keirthana merged commit 78c1ff8 into canonical:next-release Jan 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants