Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Change workflows to publish the snap to Store for Nvidia testing #170

Merged
merged 10 commits into from
Aug 26, 2024

Conversation

locnnil
Copy link
Contributor

@locnnil locnnil commented Aug 21, 2024

Add possibility to run nvidia workflow for artifacts of PRs and separate build and upload artifact on a dedicated workflow.

  • Add: workflow to build and upload artifact
  • Feat: Add possibility to run nvidia tests by passing the run-id of the wanted build workflow.

hartmutobendorf added a commit to hartmutobendorf/docker-snap that referenced this pull request Aug 21, 2024
canonical#170

added ssh-keys interface
added ssh-public-keys interface
added openssh-client for staging
added bind-file layout for /use/bin/ssh
hartmutobendorf added a commit to hartmutobendorf/docker-snap that referenced this pull request Aug 21, 2024
canonical#170

added ssh-keys interface
added ssh-public-keys interface
added openssh-client for staging
added bind-file layout for /use/bin/ssh
@hartmutobendorf
Copy link

sorry for causing confusion, the reference was meant to be to an issue, not this pr

@locnnil locnnil force-pushed the IENG-1142-store-publish-workflow branch from 826a7b4 to 81654e7 Compare August 22, 2024 23:17
Improve Nvidia test with using the last builded artifact

Signed-off-by: Lincoln Wallace <[email protected]>
@locnnil locnnil force-pushed the IENG-1142-store-publish-workflow branch from 81654e7 to aec17df Compare August 23, 2024 21:57
@locnnil locnnil marked this pull request as ready for review August 23, 2024 21:57
@locnnil
Copy link
Contributor Author

locnnil commented Aug 23, 2024

I suspect that the smoke-tests workflow isn’t being triggered because the “Build” workflow doesn’t exist in main branch.

@locnnil locnnil requested a review from farshidtz August 25, 2024 01:36
.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/nvidia-test.yml Show resolved Hide resolved
.github/workflows/smoke-test.yml Outdated Show resolved Hide resolved
.github/workflows/smoke-test.yml Outdated Show resolved Hide resolved
.github/workflows/smoke-test.yml Outdated Show resolved Hide resolved
Signed-off-by: Lincoln Wallace <[email protected]>
@locnnil locnnil requested a review from farshidtz August 25, 2024 20:23
Signed-off-by: Lincoln Wallace <[email protected]>
@locnnil locnnil force-pushed the IENG-1142-store-publish-workflow branch from 1a51e01 to c7fd410 Compare August 26, 2024 02:28
@farshidtz farshidtz changed the title add: pr-branch store publish workflow Change GH workflows to publish the snap to Store for Nvidia testing Aug 26, 2024
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks. Need to merge to test the workflow triggers.

@farshidtz farshidtz merged commit 3dd32f1 into canonical:main Aug 26, 2024
1 check passed
@farshidtz
Copy link
Member

The smoke test workflow fails during the artifact download step.
https://github.com/canonical/docker-snap/actions/runs/10555183107/job/29238305965

Run dawidd6/action-download-artifact@v6
  with:
    workflow: build.yml
    name: docker_[0-9]+.snap
    name_is_regexp: true
    github_token: ***
    workflow_search: false
    workflow_conclusion: success
    repo: canonical/docker-snap
    path: ./
    allow_forks: false
    check_artifacts: false
    search_artifacts: false
    skip_unpack: false
    if_no_artifact_found: fail
==> Repository: canonical/docker-snap
==> Artifact name: docker_[0-[9](https://github.com/canonical/docker-snap/actions/runs/10555183107/job/29238305965#step:3:9)]+.snap
==> Local path: ./
==> Workflow name: build.yml
==> Workflow conclusion: success
==> Allow forks: false
Error: Not Found - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-workflow

Looks like it is can't find the workflow because the given workflow name (build.yml) doesn't match the actual name (build.yaml).

farshidtz added a commit that referenced this pull request Aug 26, 2024
This workflow has been added in #170

But the file name doesn't match the name given in the download steps in smoke and nvidia tests.

Renaming to yml because this makes the extension consistent with other workflows in this repo.
locnnil pushed a commit that referenced this pull request Aug 26, 2024
This workflow has been added in #170

But the file name doesn't match the name given in the download steps in smoke and nvidia tests.

Renaming to yml because this makes the extension consistent with other workflows in this repo.
@farshidtz farshidtz changed the title Change GH workflows to publish the snap to Store for Nvidia testing ci: Change workflows to publish the snap to Store for Nvidia testing Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants