grafana source uid added to grafana-source interface #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
michaeldmitry
force-pushed
the
grafana_source_uid_share
branch
from
f8227b0 to
82dc57d
Compare
mmkay
approved these changes
Nov 28, 2024
michaeldmitry
force-pushed
the
grafana_source_uid_share
branch
from
623d8e0 to
8c4b37b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The grafana source providers need to receive back from grafana the UIDs assigned to them. This, to support cross-referencing functionalities such as canonical/tempo-coordinator-k8s-operator#77.
Tandem PR in prometheus to forward this data to remote-write integrations
Solution
added a
grafana_source_uids: Dict[unit_name: source_uid]field to the application databag on the grafana side.All changes are additive and therefore backwards-compatible.