forward grafana source UIDs #647
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I get the intention behind this but it seems like this might be much cleaner if we went the direction with a separate interface ( |
|
I agree with @mmkay on this one, and as such, will close this pr. |
|
this must have been my feverish brain, but yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
the
grafana_datasourceinterface has been updated to give prometheus back the datasource UID provisioned for its units.This PR instructs prometheus to forward those UIDs over remote-write, so that applications remote-writing to prometheus, such as Tempo or Loki, can obtain the datasource UIDs that have been created for their datasources.
Tandem PR: canonical/grafana-k8s-operator#359