Fix name of secureboot requirement
#167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
tomponline
reviewed
May 2, 2024
bin/test-image
Outdated
| # Some distros don't support secure boot. | ||
| case "${DISTRO}" in | ||
| alpine|archlinux|gentoo|nixos) | ||
| lxc config set "${TEST_IMAGE}" security.secureboot=true |
There was a problem hiding this comment.
shouldnt this be false?
Whats with the ) at the end but no starting bracket, is this some weird bash-ism?
There was a problem hiding this comment.
Oh, indeed, false it should have been. Fixed, thanks.
As for the ) missing the opening one, it is not a bashism but now that you call it out it looks weird. man dash:
The syntax of the case command is
case word in
[(]pattern) list ;;
...
esac
The pattern can actually be one or more patterns (see Shell Patterns described later), separated by “|” characters.
The “(” character before the pattern is optional.
I don't remember seeing case with an opening ( though. I'm fine introducing it if that reads better for you.
There was a problem hiding this comment.
Ah ok thanks, from my PHP, Java, Go, C eyes thats a definite code smell, but seems like its ok in shell.
Signed-off-by: Simon Deziel <[email protected]>
While copying even 1GiB worth of a desktop VM image is quick, it wastes disks and is not needed as `lxc image import` is only reading from the source files. Signed-off-by: Simon Deziel <[email protected]>
https://www.freedesktop.org/software/systemd/man/latest/sd_booted.html: > Internally, this function checks whether the directory /run/systemd/system/ > exists. A simple check like this can also be implemented trivially in shell > or any other language. Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Previously, a failure from `./bin/test-image` would abort immediatly due to `set -e`. Now, we get a chance of echo'ing that it failed. Signed-off-by: Simon Deziel <[email protected]>
tomponline
approved these changes
May 2, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes canonical/lxd#13409
Also, fix/improve a few things along the way.
It's too bad that
bin/test-imagecannot consult the image requirements otherwise it would have been possible to look if the image being tested is not going to work withsecureboot. For now I hardcoded the known incompatible distros but if @MusicDin you know better, please let me know!