-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auth: Add entitlements to LXD entities (part 1: introduce IsFineGrained
field)
#14745
base: main
Are you sure you want to change the base?
auth: Add entitlements to LXD entities (part 1: introduce IsFineGrained
field)
#14745
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"resources" means something else in LXD as we have /1.0/resources
so we should find a different name for this conceptual change.
Would entities be more appropriate?
Yes, entities seems better. I'll change the naming. Thanks! |
a6cab4d
to
7462cae
Compare
IsFineGrained
field)IsFineGrained
field)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the changes as discussed, thanks.
Please update the PR description to demonstrate the actual API change being made here. Ta
d87a4ea
to
88c7bae
Compare
54150d6
to
243c70b
Compare
243c70b
to
c4d0b14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of small nits :)
Adds `fine_grained` field to `GET /1.0/auth/identities/current` to indicate if the current identity interacting with the LXD API is fine-grained (i.e, associated permissions are managed via group membership) and allow LXD entities to be returned with an `entitlements` field if the current identity is fine-grained and if the GET request to fetch the LXD entities has the `with-entitlements=<comma_separated_list_of_candidate_entitlements>` query parameter. Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
c4d0b14
to
afb39f8
Compare
…ies/current` endpoint This is needed to let know the client if the currently used identity is fine-grained or not. Signed-off-by: Gabriel Mougard <[email protected]>
afb39f8
to
f7b3a8c
Compare
…e-allocated) Signed-off-by: Gabriel Mougard <[email protected]>
… current identity info Signed-off-by: Gabriel Mougard <[email protected]>
f7b3a8c
to
1db1638
Compare
JIRA ticket: https://warthogs.atlassian.net/browse/LXD-2208
Specification link: https://docs.google.com/document/d/1GxWV5J57MLrjGEY5RDG7eS86J99A8RMmjKTpn0mEhgY/edit?tab=t.0
This is the first part of a group of three stacked PRs.
This introduces a new
FineGrained
boolean field inIdentityInfo
(returned fromGET /1.0/auth/identities/current
) to let a user know if he is currently using a fine grained authentication method. This PR also introduce theentities_with_entitlements
extension.How to query the API using fine grained auth (this is just a reminder for me)
The CURL output should give you something like: