auth: Add entitlements to LXD resources (part 3: Enrich LXD resources with entitlements) #14748
+553
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Documentation
gabrielmougard
force-pushed
the
feat/auth-dry-run-check-part3
branch
11 times, most recently
from
d5f0001 to
3cae833
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gabrielmougard
force-pushed
the
feat/auth-dry-run-check-part3
branch
2 times, most recently
from
e653ad9 to
7f5457a
Compare
gabrielmougard
force-pushed
the
feat/auth-dry-run-check-part3
branch
2 times, most recently
from
171b326 to
1a09849
Compare
minaelee
reviewed
Jan 10, 2025
gabrielmougard
force-pushed
the
feat/auth-dry-run-check-part3
branch
from
1a09849 to
e18b874
Compare
|
@minaelee thanks for the feedbacks. Fixing that right now |
Adds `fine_grained` field to `GET /1.0/auth/identities/current` to indicate if the current identity interacting with the LXD API is fine-grained (i.e, associated permissions are managed via group membership) and allow LXD entities to be returned with an `entitlements` field if the current identity is fine-grained and if the GET request to fetch the LXD entities has the `with-entitlements=<comma_separated_list_of_candidate_entitlements>` query parameter. Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
gabrielmougard
force-pushed
the
feat/auth-dry-run-check-part3
branch
3 times, most recently
from
b265876 to
6f763e7
Compare
gabrielmougard
force-pushed
the
feat/auth-dry-run-check-part3
branch
from
6f763e7 to
c793358
Compare
edlerd
reviewed
Jan 10, 2025
There was a problem hiding this comment.
Shall we add a test case like the one below?
A restricted user has some entitlements on a project. Request the project list with that user and with a list of entitlements. Then assert the api response contains the correct list of entitlements for that project. Maybe request some entitlements the user has on the project, and some that the user has not to make it cover all the possible cases.
If we build this test case reusable, we can repeat it for all the different entity types, but not sure if that level of coverage is needed.
There was a problem hiding this comment.
Yes, that seems like a good test case. I can try to build a reusable one for a couple of entities (instance, volume, or other ones you think might be useful for your use case)
…ies/current` endpoint This is needed to let know the client if the currently used identity is fine-grained or not. Signed-off-by: Gabriel Mougard <[email protected]>
gabrielmougard
force-pushed
the
feat/auth-dry-run-check-part3
branch
from
c793358 to
ed0cbfa
Compare
…e-allocated) Signed-off-by: Gabriel Mougard <[email protected]>
… current identity info Signed-off-by: Gabriel Mougard <[email protected]>
…e `Authorizer` interface These methods return the entitlements corresponding to the entity/entities through calls to the OpenFGA datastore. These functions should be called at the end of a LXD API handler so that the OpenFGA per-request cache can be hit. Signed-off-by: Gabriel Mougard <[email protected]>
… eligible LXD entities Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
gabrielmougard
force-pushed
the
feat/auth-dry-run-check-part3
branch
from
ed0cbfa to
6725a64
Compare
minaelee
reviewed
Jan 13, 2025
| @@ -623,6 +623,12 @@ func storagePoolVolumesGet(d *Daemon, r *http.Request) response.Response { | |||
| return response.SmartError(err) | |||
| } | |||
|
|
|||
| // Detect if we want to also returns entitlements for each volume. | |||
There was a problem hiding this comment.
Suggested change
| // Detect if we want to also returns entitlements for each volume. | |
| // Detect if we want to also return entitlements for each volume. |
| @@ -2016,6 +2035,12 @@ func storagePoolVolumeGet(d *Daemon, r *http.Request) response.Response { | |||
| return response.SmartError(err) | |||
| } | |||
|
|
|||
| // Detect if we want to also returns entitlements for each volume. | |||
There was a problem hiding this comment.
Suggested change
| // Detect if we want to also returns entitlements for each volume. | |
| // Detect if we want to also return entitlements for each volume. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third part of a group of three stacked PRs.
IsFineGrainedfield) #14745