Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: use canonical/setup-lxd action to setup LXD #592

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

simondeziel
Copy link
Member

@simondeziel simondeziel commented Jul 4, 2024

Fixes #586, probably due to sudo -g lxd not preserving the $PATH in which
the actions/setup-python had put the python executable.

@simondeziel simondeziel force-pushed the setup-lxd branch 2 times, most recently from 45bb547 to 7ef70a3 Compare July 4, 2024 19:53
Fixes canonical#586, probably due to `sudo -g lxd` not preserving the `$PATH` in which
the actions/setup-python had put the python executable.

Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel simondeziel requested a review from hamistao July 4, 2024 20:11
@simondeziel simondeziel marked this pull request as ready for review July 4, 2024 20:12
Copy link
Contributor

@hamistao hamistao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM. Before merging, I think this could also use a description on the PR for what it is changing since this changes the behavior of the tests and makes use of an external implementation (i.e. canonical/setup-lxd).

@simondeziel simondeziel merged commit 8cdadd4 into canonical:main Jul 5, 2024
16 checks passed
@simondeziel simondeziel deleted the setup-lxd branch July 5, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CI to actually test against various Python versions
2 participants