Fix test regression on LXD 4.0 #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamistao
force-pushed
the
fix_snapshot_crete_regression
branch
2 times, most recently
from
062f30c to
76bf24b
Compare
hamistao
force-pushed
the
fix_snapshot_crete_regression
branch
from
76bf24b to
5694ecb
Compare
simondeziel
reviewed
Jul 5, 2024
hamistao
force-pushed
the
fix_snapshot_crete_regression
branch
from
5694ecb to
f6a01d2
Compare
hamistao
changed the title
hamistao
force-pushed
the
fix_snapshot_crete_regression
branch
8 times, most recently
from
f014738 to
b5ebdc5
Compare
simondeziel
reviewed
Jul 5, 2024
hamistao
force-pushed
the
fix_snapshot_crete_regression
branch
from
e6d2aac to
7c3ff77
Compare
hamistao
force-pushed
the
fix_snapshot_crete_regression
branch
6 times, most recently
from
8508894 to
2bd52ef
Compare
|
@simondeziel This is ready for a review. The changes should be better explained on the commit messages, if anything is still confusing let me know. |
simondeziel
reviewed
Jul 8, 2024
simondeziel
reviewed
Jul 8, 2024
Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
Older LXD versions' APIs don't include: The `created_at` field, the `expires_at` field on /1.0/storage-pools/<pool>/volumes/custom/<volume_name>/snapshots, The `content_type` on /1.0/storage-pools/<pool>/volumes/custom/<volume_name>/snapshots/<snapshot_name>. Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
hamistao
force-pushed
the
fix_snapshot_crete_regression
branch
from
2bd52ef to
9137f09
Compare
|
@simondeziel This should be ready to merge |
simondeziel
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #590.
Unfortunately, the best possible solution for
createis picking the latest snapshot name when getting the object after creation.This is prone to error if multiple snapshots of the same volume are being taken concurrently. But since this isn't a realistic use case, these changes should be acceptable in favor of not hurting UX by returning an empty object.