fix(remote): fallback to legacy snapcraft if under shallow git clone #4498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4498 +/- ##
==========================================
+ Coverage 89.18% 89.20% +0.01%
==========================================
Files 321 321
Lines 21727 21755 +28
==========================================
+ Hits 19378 19407 +29
+ Misses 2349 2348 -1 ☔ View full report in Codecov by Sentry. |
syu-w
requested review from
mr-cal and
lengau
and removed request for
mr-cal
syu-w
force-pushed
the
work/CRAFT-2335-shallow-clone
branch
2 times, most recently
from
8a70c19 to
7d482c8
Compare
Git shallow clone is not pushable by design. Fallback to legacy remote build which has workaround. This only support core20 and core22. Any other bases and devel will report error.
syu-w
force-pushed
the
work/CRAFT-2335-shallow-clone
branch
from
7d482c8 to
4527498
Compare
lengau
approved these changes
Dec 14, 2023
mr-cal
reviewed
Dec 15, 2023
There was a problem hiding this comment.
Good start but there are a few code smells. The business logic in the flowchart had 4 checks and 2 outcomes (either running the new or legacy remote-build).
The code here is now out-of-order with the flowchart, introduces more checks, and adds more outcomes (raising exceptions within the business logic).
mr-cal
requested changes
Dec 15, 2023
lengau
approved these changes
Dec 15, 2023
1 task
syu-w
added a commit
that referenced
this pull request
Jan 29, 2024
Shallow git repos are not designed to be pushed, so the new remote-builder now raises an error for shallowly cloned repos. core20 and core22 projects in shallow clone repos fall back to the legacy remote-builder to retain compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git shallow clone is not pushable by design. Fallback to legacy remote build which has workaround. This only support core20 and core22. Any other bases and devel will report error.