Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Reset date range calendar when value is empty string or array #17889

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dedanade
Copy link
Contributor

Closes #17702

Fix issue when a user resets datepicker calendar using an empty string, array, or two empty strings in an array.

Changelog

New

  • {{new thing}}

Changed

  • {{change thing}}

Removed

  • {{removed thing}}

Testing / Reviewing

Create a button to reset the date range in DatePicker.stories to reset the calendar with a daterange value like this https://stackblitz.com/edit/github-cmfaqv?file=src%2FApp.jsx.

Select the start and end date, click on the reset button you created above and reselect start date again to notice the end date doesn't automatically populate from the previous selection.

@dedanade dedanade requested a review from a team as a code owner October 28, 2024 00:48
Copy link
Contributor

github-actions bot commented Oct 28, 2024

Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


1 out of 2 committers have signed the DCO.
✅ (emyarod)[https://github.com/emyarod]
@daniel Adebonojo
Daniel Adebonojo seems not to be a GitHub user. You need a GitHub account to be able to sign the DCO. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot.

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 9cd80bd
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/672e2f1853e510000721e6d0
😎 Deploy Preview https://deploy-preview-17889--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dedanade
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 9cd80bd
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/672e2f180d670c000891b0c7
😎 Deploy Preview https://deploy-preview-17889--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like VS Code is adding .history to the repo but we probably don't need to commit those files!

@dedanade
Copy link
Contributor Author

dedanade commented Nov 4, 2024

it looks like VS Code is adding .history to the repo but we probably don't need to commit those files!

Hi @emyarod, Apologies, This is coming from a different commit that has been fixed and unrelated to this task. It looks good to me now.

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 9cd80bd
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/672e2f18fa18080008e5078f
😎 Deploy Preview https://deploy-preview-17889--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guidari
Copy link
Contributor

guidari commented Nov 21, 2024

Hey @dedanade The Stackblitz does not work.
Can you create an example story for us to test, please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants