Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Reset date range calendar when value is empty string or array #17889

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix: Reset date range calendar when value is empty string or array #17889

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
983d219
fix: remove loading animation in inlineloading inactive state
Oct 20, 2024
8f4d2e8
fix: resetting datepicker range with calendar using empty string/array
Oct 28, 2024
e861653
Revert "fix: remove loading animation in inlineloading inactive state"
Nov 4, 2024
30200cd
Merge branch 'main' into reset-date-range-calendar
emyarod Nov 5, 2024
9cd80bd
Merge branch 'main' into reset-date-range-calendar
emyarod Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/react/src/components/DatePicker/DatePicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -897,7 +897,15 @@ const DatePicker = React.forwardRef(function DatePicker(
useEffect(() => {
if (calendarRef?.current?.set) {
if (value !== undefined) {
calendarRef.current.setDate(value);
// To make up for calendarRef.current.setDate not making provision for an empty string or array
if (
value === '' ||
(Array.isArray(value) && value.every((element) => element === ''))
) {
calendarRef.current.clear();
} else {
calendarRef.current.setDate(value);
}
}
updateClassNames(calendarRef.current, prefix);
//for simple date picker w/o calendar; initial mount may not have value
Expand Down
Loading