refactor: Unzip Android deps*.zip #5907
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Purpose of change
Pre-compressing the android dependencies into a zip is redundant as Git gzips blobs anyways. Squishing everything into deps.zip just means dependencies can't be modified without uploading a new binary blob of all the dependencies.
This is relevant for #5777 , as that PR introduces new dependencies (sqlite) for the first time in ~3 years.
Describe the solution
This commit removes the deps.zip setup and leaves all the dependencies as loose files in the repo.
NOTE: This does remove the '-Pdeps' functionality which makes it easier to swap out dependencies with debug binaries, but I'm doubtful it's worth the cost and if anyone is actively using that. Holler at me if this is an issue.
Describe alternatives you've considered
We could leave this setup as-is and just package new dependencies into
deps.zip
anddeps_debug.zip
, but (1) I'm not a fan of mysterious zip files with no traceable provenance, and (2) that just kicks the issue down the road if we ever want to update or add more dependencies in the future.Testing
CI compile test. Once it builds we'll see if it runs.
Additional context