Removed resetting checkpolicy to 0 #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line 119 commented out: Agreement to policy is triggered before the signup form, this would reset it
auth.php
Outdated
| @@ -116,7 +116,7 @@ public function user_signup($user, $notify=true) { | |||
| $user->picture = 0; | |||
| $user->imagealt = 0; | |||
| $user->deleted = 0; | |||
| $user->policyagreed = 0; | |||
| // $user->policyagreed = 0; // Agreement to policy is triggered before the signup form, this would reset it | |||
There was a problem hiding this comment.
Please don't comment out code in the patch, just either fix it to what it should be or remove the line completely.
The CI was complaining because comments must end with punctuation:
https://travis-ci.org/catalyst/moodle-auth_enrolkey/jobs/652233553#L891
There was a problem hiding this comment.
I corrected the PR (hopefully). I find all this Github stuff more than confusing...
Corrected the PR (removed line completely)
|
Hmm I'm not sure it's that simple, I think this needs to take the emailconfirmation setting into account. Leave it with us please |
|
This issue will be fix in: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #38
Line 119 commented out: Agreement to policy is triggered before the signup form, this would reset it