Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed resetting checkpolicy to 0 #39

Closed
wants to merge 2 commits into from
Closed

Removed resetting checkpolicy to 0 #39

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a792297
Update auth.php
VOOM108 Feb 18, 2020
a024851
Update auth.php
VOOM108 Feb 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion auth.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ public function user_signup($user, $notify=true) {
$user->picture = 0;
$user->imagealt = 0;
$user->deleted = 0;
$user->policyagreed = 0;
// $user->policyagreed = 0; // Agreement to policy is triggered before the signup form, this would reset it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't comment out code in the patch, just either fix it to what it should be or remove the line completely.

The CI was complaining because comments must end with punctuation:

https://travis-ci.org/catalyst/moodle-auth_enrolkey/jobs/652233553#L891

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I corrected the PR (hopefully). I find all this Github stuff more than confusing...

$user->id = user_create_user($user, false, false);

// Save any custom profile field information.
Expand Down