PR Td/values+sa try2 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gert-Jaap Glasbergen <[email protected]>
Signed-off-by: Gert-Jaap Glasbergen <[email protected]>
Signed-off-by: Gert-Jaap Glasbergen <[email protected]>
Signed-off-by: Gert-Jaap Glasbergen <[email protected]>
Signed-off-by: Gert-Jaap Glasbergen <[email protected]>
In particular, several of the commits in this set assume their `blocking_queue`s will be empty by the time the destructor is called. However, this is not guaranteeable, and causes segfaults and/or indefinite hangs when encountered. This commit predominantly ensures that the queues are all `clear()`d appropriately. Signed-off-by: Sam Stuewe <[email protected]>
Includes: * executes outside docker, creating a single process per-component * takes a config file and executes accordingly * automatically generates some graphs for the run * supports running all components under debuggers/valgrind/perf * creates and caches preseeds as-specified * preserves benchmark artifacts out-of-tree Co-authored-by: Michael Maurer <[email protected]> Signed-off-by: Sam Stuewe <[email protected]>
Signed-off-by: Sam Stuewe <[email protected]>
Signed-off-by: James Lovejoy <[email protected]>
Co-authored-by: Sam Stuewe <[email protected]> Signed-off-by: James Lovejoy <[email protected]>
…atomizer integration tests Signed-off-by: James Lovejoy <[email protected]>
Signed-off-by: James Lovejoy <[email protected]>
Co-authored-by: Sam Stuewe <[email protected]> Signed-off-by: James Lovejoy <[email protected]>
Signed-off-by: James Lovejoy <[email protected]>
Do not skip audit if there was no previous audit running Signed-off-by: James Lovejoy <[email protected]>
Signed-off-by: Sam Stuewe <[email protected]>
Right now, the values implementation is quite a bit more bloated than it needs to be; the input side of a transaction only needs to be the UHS ids (just the hashes), not the full UHS element. Because the benchmarks were largely written against the cryptographic commitment code (for which this optimization has an outsized effect), they assumed this would be the case. For now, instead of implementing this optimization in the values solution, we just ensure the benchmarks behave correctly. In the long-run, if this branch should stay around, we should correctly minimize the input-side of compact transactions. Signed-off-by: Sam Stuewe <[email protected]>
Should awaken the TC Signed-off-by: Sam Stuewe <[email protected]>
If the shards and coordinators sit inside the secure perimeter, and the coordinator is trusted to validate sentinel attestations honestly, the shard is just duplicating effort for no benefit by checking them. Signed-off-by: Sam Stuewe <[email protected]>
This sets up the 2PC load-generator to read the config values the Test Controller already supports* to limit throughput to a set amount, optionally increasing it according to a definable schedule. Among other benefits, this allows the tester to constrain load-generators directly rather than by relying on the preseed count to artifically reduce their load. This also includes the relevant config changes to enable respected per-loadgen log-levels. Signed-off-by: Sam Stuewe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.