-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make strict rules on amd64 experimental builds #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I don't understand why we are doing this change. The linked issue points to a problem with arm builds but this change is impact the amd images.
Additionally this is just limiting what triggers the builds but does nothing to change the image itself which is what the issue is related to.
Please provide additional context to why we are doing this change.
Please take a look here: This is a job that was building the main branch. As you can see the amd64 shouldn't build 1 image twice in 2 jobs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, otherwise LGTM
github.ref != 'refs/heads/main' && | ||
!startsWith(github.ref, 'refs/tags/v') && | ||
!contains(github.ref, '-rc') && | ||
github.event.pull_request.head.repo.full_name == github.event.pull_request.base.repo.full_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means it does not build on a fork, which should happen, to report back an error to the developer if something breaks.
Building it always and only pushing on non-forks results in that behavior.
closing in favor off #77 |
Pull request was closed
Overview
Closes https://github.com/celestiaorg/devops/issues/527
Checklist