Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make strict rules on amd64 experimental builds #76

Closed
wants to merge 3 commits into from

Conversation

Bidon15
Copy link
Member

@Bidon15 Bidon15 commented Sep 20, 2023

Overview

Closes https://github.com/celestiaorg/devops/issues/527

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@Bidon15 Bidon15 requested review from MSevey and a team as code owners September 20, 2023 12:11
@Bidon15 Bidon15 self-assigned this Sep 20, 2023
@Bidon15 Bidon15 enabled auto-merge (squash) September 20, 2023 12:28
tty47
tty47 previously approved these changes Sep 20, 2023
Copy link
Contributor

@tty47 tty47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@MSevey MSevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I don't understand why we are doing this change. The linked issue points to a problem with arm builds but this change is impact the amd images.

Additionally this is just limiting what triggers the builds but does nothing to change the image itself which is what the issue is related to.

Please provide additional context to why we are doing this change.

@Bidon15
Copy link
Member Author

Bidon15 commented Oct 10, 2023

In general I don't understand why we are doing this change. The linked issue points to a problem with arm builds but this change is impact the amd images.

Additionally this is just limiting what triggers the builds but does nothing to change the image itself which is what the issue is related to.

Please take a look here:
https://github.com/celestiaorg/celestia-node/actions/runs/6458347843/job/17532066994

This is a job that was building the main branch. As you can see the amd64 shouldn't build 1 image twice in 2 jobs.
We need to remove this effect to make sure it's not the root cause of the issues we see with amd64 being marked as arm64

Copy link
Member

@smuu smuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM

github.ref != 'refs/heads/main' &&
!startsWith(github.ref, 'refs/tags/v') &&
!contains(github.ref, '-rc') &&
github.event.pull_request.head.repo.full_name == github.event.pull_request.base.repo.full_name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means it does not build on a fork, which should happen, to report back an error to the developer if something breaks.
Building it always and only pushing on non-forks results in that behavior.

@MSevey
Copy link
Member

MSevey commented Oct 11, 2023

closing in favor off #77

@MSevey MSevey closed this Oct 11, 2023
auto-merge was automatically disabled October 11, 2023 14:08

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants