Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: clean up logic in docker build workflow to cleanly separate … #77

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

MSevey
Copy link
Member

@MSevey MSevey commented Oct 10, 2023

…prs and merges

Overview

This workflow has been buggy for a while due to the splitting of the two build steps and the differences in the teams work flow. The issue from https://github.com/celestiaorg/devops/issues/527 came down to the same commit being present on the PR as well as on main, thus causing the new docker images not to be built. This can happen based on how the team creates branches, forks, PRs, etc.

The workflow now runs with the following logic:

  • Forks do not push images
  • There is one step for PRs and one step for merges to main, they do not run at the same time.
  • Caches are not used
  • On PRs, we build one image for testing
  • On merges to main, we build all images needed

This PR is a replacement of #76

@MSevey MSevey requested a review from a team as a code owner October 10, 2023 14:33
@MSevey MSevey force-pushed the sevey/docker-refactor branch from 818ea85 to 80e99c4 Compare October 10, 2023 14:41
Copy link
Contributor

@tty47 tty47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🪨 🚀

@MSevey MSevey enabled auto-merge (squash) October 11, 2023 14:04
@MSevey MSevey merged commit 75f14f3 into main Oct 11, 2023
8 checks passed
@MSevey MSevey deleted the sevey/docker-refactor branch October 11, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants