-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: generate pre-built binaries for darwin and arm64 #2654
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2654 +/- ##
=======================================
Coverage 21.11% 21.11%
=======================================
Files 138 138
Lines 15767 15767
=======================================
Hits 3329 3329
Misses 12115 12115
Partials 323 323 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should be adding some of this information to our public docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Closes #2567 ## Testing Testing with binaries on [my fork](https://github.com/rootulp/celestia-app/releases/tag/v1.0.0-rc5). | os | arch | machine | works | notes | |--------|----------------|---------------|-------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | darwin | arm64 | Rootul's MBP | ✅ | I had to circumvent [Apple can't check app for malicious software](https://support.apple.com/guide/mac-help/apple-cant-check-app-for-malicious-software-mchleab3a043/mac) | | darwin | amd64 (x86_64) | AWS | ✅ | | | linux | arm64 | AWS | ✅ | | | linux | amd64 (x86_64) | Digital Ocean | ✅ | | (cherry picked from commit a692125)
…#2662) This is an automatic backport of pull request #2654 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Rootul P <[email protected]>
Closes #2567
Testing
Testing with binaries on my fork.