doc: update PFM spec #293
Closed
doc: update PFM spec #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
commented
Apr 12, 2022
| @@ -113,15 +113,15 @@ if err != nil { | |||
| } | |||
|
|
|||
| // query for account information necessary to sign a valid tx | |||
| err = keyringSigner.QueryAccount(ctx, grpcClientConn) | |||
| err = keyringSigner.QueryAccountNumber(ctx, grpcClientConn) | |||
There was a problem hiding this comment.
Is this the method we should be using?
There was a problem hiding this comment.
this brings up a really good point. This method appears to be vestigial, and should likely not be exported. Instead, it should be private and only called during the keyringSigner's BroadcastTx method.
There was a problem hiding this comment.
For the moment though, is this a necessary component to building and submitting a PFD?
|
what is the status of this PR? |
|
I think we can close, as I believe we covered this issue synchronously but will defer to @renaynay |
|
We can close this. We should probably provide docs on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mostly made this PR to track some misunderstandings I had with the spec for using PFM.