Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate simplifying KeyringSigner api #294

Closed
evan-forbes opened this issue Apr 12, 2022 · 5 comments
Closed

Investigate simplifying KeyringSigner api #294

evan-forbes opened this issue Apr 12, 2022 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@evan-forbes
Copy link
Member

per dicsussion in #293 (comment) we should be able to simplify the API for the KeyringSigner by unexporting QueryAccount

@evan-forbes
Copy link
Member Author

evan-forbes commented Apr 17, 2022

after thinking about this more, I'm not sure that we should do this exact change, as we need to sign the share commitments after we query for the account number, and the user will need precise control over that depending on how non-interactive defaults play out. We should still take another look at simplifying the API though. @renaynay had a good idea to have a single large function to the default case for the user. I think this is definitely something we should look into.

@evan-forbes evan-forbes changed the title Simplify KeyringSigner api by unexporting the QueryAccount method Investigate simplifying KeyringSigner api Apr 17, 2022
@renaynay
Copy link
Member

It would make my life a lot easier if the canonical implementation of constructing + signing a PFD existed in celestia-app @evan-forbes

@renaynay
Copy link
Member

I have the initial implementation here:

celestiaorg/celestia-node#619

@evan-forbes
Copy link
Member Author

We should be able to not use the keyring signer after implementing #951

@evan-forbes evan-forbes added this to the Mainnet milestone Jan 18, 2023
@evan-forbes evan-forbes removed this from the Mainnet milestone Apr 2, 2023
@evan-forbes
Copy link
Member Author

can close with addition of the canonical mechanism for submitting a PFB and the user package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants