-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate simplifying KeyringSigner
api
#294
Comments
after thinking about this more, I'm not sure that we should do this exact change, as we need to sign the share commitments after we query for the account number, and the user will need precise control over that depending on how non-interactive defaults play out. We should still take another look at simplifying the API though. @renaynay had a good idea to have a single large function to the default case for the user. I think this is definitely something we should look into. |
KeyringSigner
api by unexporting the QueryAccount
methodKeyringSigner
api
It would make my life a lot easier if the canonical implementation of constructing + signing a PFD existed in celestia-app @evan-forbes |
I have the initial implementation here: |
We should be able to not use the keyring signer after implementing #951 |
can close with addition of the canonical mechanism for submitting a PFB and the user package |
per dicsussion in #293 (comment) we should be able to simplify the API for the
KeyringSigner
by unexportingQueryAccount
The text was updated successfully, but these errors were encountered: