test: increase test coverage for governance params #3007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add auth, blob, blobstream, and consensus governance param tests add governance params tests for distribution add tests for modifying gov params add tests for modifying ibc params add tests for modifying slashing params add tests for modifying staking params ci: remove version_bump job (celestiaorg#2962) Closes celestiaorg#2884 - Remove the version_bump and branch_name jobs - Extract the goreleaser jobs to a new file Can still create a release. See https://github.com/rootulp/celestia-app/actions/runs/7324051789/job/19947265102 docs: add column for governance modifiable params in resource_pricing (celestiaorg#2974) Addresses celestiaorg#2966 by using the governance modifiable params tests in PR All four of the params are modifiable by governance, which matches the specs in [params.md](https://github.com/celestiaorg/celestia-app/blob/main/specs/src/specs/params.md). - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords chore: remove unnecessary conversions (celestiaorg#2975) Use linter to detect unnecessary type conversions https://github.com/mdempsky/unconvert ci: enable govulncheck (celestiaorg#2969) Closes celestiaorg#2968 Supersedes celestiaorg#2744 - CI workflow is inspired by https://github.com/celestiaorg/celestia-core/blob/main/.github/workflows/govulncheck.yml - Bumped to Go 1.21.5 to resolve some vulnerabilities identified by govulncheck improve naming of governance params test suite fix govHandler and remove test for an unmodifiable param. remove unneeded minter setup
test: prefer assert
rootulp
added
testing
WalkthroughThe update introduces a test suite dedicated to ensuring the governance modifiability of parameters as specified in the project documentation. It verifies that parameters marked as modifiable can indeed be altered through governance proposals and that those marked as non-modifiable are resistant to such changes. This enhances the robustness of the project's governance mechanisms by aligning automated testing with the governance specifications. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
5 tasks
staheri14
reviewed
Jan 23, 2024
staheri14
previously approved these changes
Jan 24, 2024
evan-forbes
previously approved these changes
Jan 24, 2024
rootulp
requested review from
evan-forbes and
staheri14
and removed request for
a team,
cmwaters and
ninabarbakadze
staheri14
approved these changes
Jan 25, 2024
rootulp
requested review from
cmwaters,
ninabarbakadze and
evan-forbes
and removed request for
evan-forbes
|
Hoping to get this merged before another go.work.sum merge conflict shows up 💀 |
evan-forbes
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2916 with heavy inspiration from PRs by @fahimahmedx
Opens #2972