feat!: disable x/blobstream in v2 #3310
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
Could it be from this: Lines 274 to 277 in 58fc315 |
|
When does this panic happen? Is it in the genesis block? |
|
IIRC it was on very early on in |
|
Yep it was from the blobstream hooks. I'll investigate how to make those hooks versioned because IIUC, we want the staking keeper to have the blobstream hooks in app v1 and not have the blobstream hooks in app v2. |
rootulp
requested review from
rach-id,
evan-forbes,
liamsi and
a team
as code owners
|
Warning Rate Limit Exceeded@rootulp has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 48 minutes and 41 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe changes primarily focus on disabling the Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
rootulp
requested review from
cmwaters
and removed request for
a team and
liamsi
A bunch of small refactors I made while working on #3310
Co-authored-by: CHAMI Rachid <[email protected]>
A bunch of small refactors I made while working on celestiaorg#3310
There was a problem hiding this comment.
nice, does this fully close #3305, specifically point 5 where we migrate state?
|
Great question! I assumed since the blobstream store key isn't registered in v2, there would be no place to store blobstream state in the multistore but I'll double check that 👀 |
I verified that the blobstream KV store doesn't exist in app version 2. I added this to EndBlocker: store := app.CommitMultiStore().GetKVStore(app.keys[blobstreamtypes.StoreKey])
size := 0
iterator := store.Iterator(nil, nil)
defer iterator.Close()
for ; iterator.Valid(); iterator.Next() {
fmt.Printf("key %v, value %v\n", iterator.Key(), iterator.Value())
size += len(iterator.Key())
size += len(iterator.Value())
}
fmt.Printf("blobstream store size %v\n", size)and when I run a node, I can see that the blobstream store does exist prior to upgrading app versions: and it does not exist after upgrading app version |
A bunch of small refactors I made while working on celestiaorg#3310
A bunch of small refactors I made while working on celestiaorg/celestia-app#3310
Closes #3305
Testing
Manually verified on a local devnet that a user can register an EVM address if the chain is on app version 1.
$ celestia-appd tx qgb register \ "$(celestia-appd keys show validator --home ${CELESTIA_APP_HOME} --bech val -a)" \ 0x966e6f22781EF6a6A82BBB4DB3df8E225DfD9485 \ --from ${KEY_NAME} \ --home ${CELESTIA_APP_HOME} \ --fees 30000utia \ --broadcast-mode block \ --yes code: 0 codespace: "" data: 12300A2E2F63656C65737469612E7167622E76312E4D7367526567697374657245564D41646472657373526573706F6E7365 events: - attributes: - index: true key: c3BlbmRlcg== value: Y2VsZXN0aWExc3B6YWU4MzNnM2E4dDQwdXN3NTAyZXR4dHo2c2czaG5meDg4OHc= - index: true key: YW1vdW50 value: MzAwMDB1dGlh type: coin_spent - attributes: - index: true key: cmVjZWl2ZXI= value: Y2VsZXN0aWExN3hwZnZha20yYW1nOTYyeWxzNmY4NHoza2VsbDhjNWxwbmpzM3M= - index: true key: YW1vdW50 value: MzAwMDB1dGlh type: coin_received - attributes: - index: true key: cmVjaXBpZW50 value: Y2VsZXN0aWExN3hwZnZha20yYW1nOTYyeWxzNmY4NHoza2VsbDhjNWxwbmpzM3M= - index: true key: c2VuZGVy value: Y2VsZXN0aWExc3B6YWU4MzNnM2E4dDQwdXN3NTAyZXR4dHo2c2czaG5meDg4OHc= - index: true key: YW1vdW50 value: MzAwMDB1dGlh type: transfer - attributes: - index: true key: c2VuZGVy value: Y2VsZXN0aWExc3B6YWU4MzNnM2E4dDQwdXN3NTAyZXR4dHo2c2czaG5meDg4OHc= type: message - attributes: - index: true key: ZmVl value: MzAwMDB1dGlh - index: true key: ZmVlX3BheWVy value: Y2VsZXN0aWExc3B6YWU4MzNnM2E4dDQwdXN3NTAyZXR4dHo2c2czaG5meDg4OHc= type: tx - attributes: - index: true key: YWNjX3NlcQ== value: Y2VsZXN0aWExc3B6YWU4MzNnM2E4dDQwdXN3NTAyZXR4dHo2c2czaG5meDg4OHcvMQ== type: tx - attributes: - index: true key: c2lnbmF0dXJl value: U1lIMjZsRHN4V2JEMzRQdVBMaFl0eXB5NTh6TzhJVHFxc09qYm5Kb0RyVUJSQlFCTEpIdHNuRXY0YXVoaUpCK0ppUExZVVJMc1lESDZ5ZUdKQ3EwaEE9PQ== type: tx - attributes: - index: true key: YWN0aW9u value: L2NlbGVzdGlhLnFnYi52MS5Nc2dSZWdpc3RlckVWTUFkZHJlc3M= type: message gas_used: "66959" gas_wanted: "210000" height: "2" info: "" logs: - events: - attributes: - key: action value: /celestia.qgb.v1.MsgRegisterEVMAddress type: message log: "" msg_index: 0 raw_log: '[{"msg_index":0,"events":[{"type":"message","attributes":[{"key":"action","value":"/celestia.qgb.v1.MsgRegisterEVMAddress"}]}]}]' timestamp: "" tx: null txhash: 60FD4A8507E95637FE97178FBB3F4E202F679D81A59E509C5E72A6815C221085Manually verify on a local devnet that a user can't register an EVM address if the chain is on app version 2.
$ celestia-appd tx qgb register \ "$(celestia-appd keys show validator --home ${CELESTIA_APP_HOME} --bech val -a)" \ 0x966e6f22781EF6a6A82BBB4DB3df8E225DfD9485 \ --from ${KEY_NAME} \ --home ${CELESTIA_APP_HOME} \ --fees 30000utia \ --broadcast-mode block \ --yes code: 37 codespace: sdk data: "" events: [] gas_used: "8786" gas_wanted: "-1" height: "0" info: "" logs: [] raw_log: 'message type /celestia.qgb.v1.MsgRegisterEVMAddress is not supported in version 2: feature not supported' timestamp: "" tx: null txhash: E378761B61CA6D29C36957DBCAE65E4CED82788735BC3CF21A86B677970BCBD9Manually verified that tx and query CLI commands don't work.
Manually verified that gRPC queries don't work