Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: disable x/blobstream in v2 #3310

Merged
merged 37 commits into from
Apr 27, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
d3d0434
feat!: disable blobstream in v2
rootulp Apr 12, 2024
753d5f6
feat: run migrations when module is removed
rootulp Apr 12, 2024
b575823
docs: state blobstream is disabled for v2
rootulp Apr 12, 2024
9bfc942
docs: remove blobstream from specs
rootulp Apr 12, 2024
31ad30e
feat: register migration boilerplate
rootulp Apr 12, 2024
a2c28f4
refactor: README and names
rootulp Apr 12, 2024
07bcfd9
Merge branch 'main' into rp/remove-blobstream
rootulp Apr 18, 2024
c3f8391
chore: disable blobstream
rootulp Apr 18, 2024
715cad5
feat: runModuleMigration
rootulp Apr 18, 2024
0e9914c
feat: alphabetize and remove blobstream v2 store key
rootulp Apr 18, 2024
119e93c
fix: typo
rootulp Apr 18, 2024
75bb0b5
feat: add commented out qgb register command
rootulp Apr 18, 2024
f1b2528
Merge branch 'main' into rp/remove-blobstream
rootulp Apr 23, 2024
ccf3b5d
feat: set hooks per version
rootulp Apr 23, 2024
d8945f7
add a test
rootulp Apr 23, 2024
ae6be09
refactor app.go
rootulp Apr 23, 2024
66ca18b
clarify test name
rootulp Apr 23, 2024
1892c99
make hooks no-op in version > 1
rootulp Apr 23, 2024
7b9dcef
revert: refactors
rootulp Apr 24, 2024
3e99bd2
revert: unnecessary changes
rootulp Apr 24, 2024
8a393ef
test: TestAfterValidatorBeginUnbonding
rootulp Apr 24, 2024
416e7fc
refactor: test
rootulp Apr 24, 2024
86ef546
test: TestAfterValidatorCreated
rootulp Apr 24, 2024
95d2e17
refactor: tests
rootulp Apr 24, 2024
4d37342
feat!: disable tx and query CLI commands
rootulp Apr 24, 2024
1e02a42
fix: lint
rootulp Apr 24, 2024
45e42e6
test: configurator
rootulp Apr 24, 2024
17daa1b
Revert "test: configurator"
rootulp Apr 24, 2024
8f84390
fix: integration test
rootulp Apr 24, 2024
fbe7354
fix: TestQueryAttestationByNonce
rootulp Apr 24, 2024
1061c24
fix: blobstream tests by using v1
rootulp Apr 24, 2024
618d592
test: manually test qgb tx commands
rootulp Apr 24, 2024
042c2e6
feat!(blobstream): disable CLI commands
rootulp Apr 24, 2024
e7be31b
revert: single-node.sh
rootulp Apr 24, 2024
f67293e
Update x/blobstream/keeper/hooks.go
rootulp Apr 25, 2024
b406002
refactor: use testEnv
rootulp Apr 25, 2024
46e9690
Merge branch 'main' into rp/remove-blobstream
rootulp Apr 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: register migration boilerplate
  • Loading branch information
rootulp committed Apr 12, 2024
commit 31ad30ea57833ea0e92fafa2bc26084e1af62944
2 changes: 2 additions & 0 deletions app/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package app
import (
"io"

migration "github.com/celestiaorg/celestia-app/v2/app/migrations"
"github.com/celestiaorg/celestia-app/v2/app/module"
"github.com/celestiaorg/celestia-app/v2/app/posthandler"
"github.com/celestiaorg/celestia-app/v2/x/minfee"
Expand Down Expand Up @@ -631,6 +632,7 @@ func New(

app.mm.RegisterInvariants(&app.CrisisKeeper)
app.configurator = module.NewConfigurator(app.appCodec, app.MsgServiceRouter(), app.GRPCQueryRouter())
app.configurator.RegisterMigration(blobstreamtypes.ModuleName, 1, migration.BlobstreamV2)
app.mm.RegisterServices(app.configurator)

// extract the accepted message list from the configurator and create a gatekeeper
Expand Down
3 changes: 3 additions & 0 deletions app/migrations/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Upgrades

This directory contains one directory per app version upgrade. For example the upgrade logic involved in upgrading from app version 1 => 2 is contained in the `v2` directory. Celestia app doesn't use the Cosmos SDK x/upgrade module to manage upgrades. Instead it uses a versioned module manager and configurator. See `app/module` for details.
8 changes: 8 additions & 0 deletions app/migrations/v2.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package migration

import sdk "github.com/cosmos/cosmos-sdk/types"

func BlobstreamV2(ctx sdk.Context) error {
// TODO: Implement migration
return nil
}