Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade to celestia-core v1.44.1-tm-v0.34.35 #4131

Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Dec 16, 2024

@rootulp rootulp added the backport:v3.x PR will be backported automatically to the v3.x branch upon merging label Dec 16, 2024
@rootulp rootulp self-assigned this Dec 16, 2024
@rootulp rootulp requested a review from a team as a code owner December 16, 2024 16:55
@rootulp rootulp requested review from staheri14 and evan-forbes and removed request for a team December 16, 2024 16:55
@rootulp rootulp enabled auto-merge (squash) December 16, 2024 16:55
Copy link
Contributor

coderabbitai bot commented Dec 16, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request involves updates to the go.mod file, focusing on dependency version changes for the github.com/tendermint/tendermint module. The version has been updated from v0.34.29 to v0.34.30, and the replacement directive has been modified to reflect the new version v1.44.1-tm-v0.34.35. The Go version remains at 1.23.1, while other dependencies and their replacements remain unchanged.

Changes

File Change Summary
go.mod - Updated github.com/tendermint/tendermint version from v0.34.29 to v0.34.30
- Modified replacement for github.com/tendermint/tendermint to v1.44.1-tm-v0.34.35

Possibly related PRs

  • chore: upgrade to Go 1.23.1 #3848: This PR updates the go.mod file to reflect a change in the Go version to 1.23.1, which is directly related to the Go version update in the main PR.
  • chore(deps): upgrade to cosmos-sdk v1.25.1 #4133: This PR also modifies the go.mod file, specifically updating the version of github.com/cosmos/cosmos-sdk, which is relevant as it involves changes to dependencies similar to those in the main PR.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 10c0313 and 1b2b20c.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • go.mod

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between da77d6f and 10c0313.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod (1 hunks)

@@ -260,5 +259,5 @@ replace (
github.com/cosmos/ledger-cosmos-go => github.com/cosmos/ledger-cosmos-go v0.12.4
github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1
github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7
github.com/tendermint/tendermint => github.com/celestiaorg/celestia-core v1.44.0-tm-v0.34.35
github.com/tendermint/tendermint => github.com/celestiaorg/celestia-core v1.44.1-tm-v0.34.35
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Dependency update requires attention in test/interchain directory

The dependency update from v1.44.0-tm-v0.34.35 to v1.44.1-tm-v0.34.35 is still referenced in test/interchain/go.mod. This needs to be synchronized to maintain consistency across the codebase.

  • test/interchain/go.mod still references v1.44.0-tm-v0.34.35
🔗 Analysis chain

LGTM: Clean dependency upgrade to celestia-core v1.44.1-tm-v0.34.35

The replace directive has been correctly updated to point to the new version of celestia-core. This patch version upgrade (v1.44.0 -> v1.44.1) aligns with the PR objectives.

Let's verify the dependency update's consistency and impact:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the dependency update's consistency and potential impact

# Check if there are any other references to the old version
rg "v1\.44\.0-tm-v0\.34\.35"

# Look for any go.sum changes that might be needed
if [ -f "go.sum" ]; then
    rg "celestia-core/v1\.44\." go.sum
fi

# Check for any potential breaking changes in the upgrade
gh api repos/celestiaorg/celestia-core/compare/v1.44.0-tm-v0.34.35...v1.44.1-tm-v0.34.35

Length of output: 58637

Copy link
Member

@ninabarbakadze ninabarbakadze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflict :/

@rootulp rootulp merged commit 9f3b196 into celestiaorg:main Dec 18, 2024
28 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:v3.x PR will be backported automatically to the v3.x branch upon merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants