-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): upgrade to celestia-core v1.44.1-tm-v0.34.35 #4131
chore(deps): upgrade to celestia-core v1.44.1-tm-v0.34.35 #4131
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request involves updates to the Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: .coderabbit.yaml ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sum
is excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
(1 hunks)
@@ -260,5 +259,5 @@ replace ( | |||
github.com/cosmos/ledger-cosmos-go => github.com/cosmos/ledger-cosmos-go v0.12.4 | |||
github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1 | |||
github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7 | |||
github.com/tendermint/tendermint => github.com/celestiaorg/celestia-core v1.44.0-tm-v0.34.35 | |||
github.com/tendermint/tendermint => github.com/celestiaorg/celestia-core v1.44.1-tm-v0.34.35 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Dependency update requires attention in test/interchain directory
The dependency update from v1.44.0-tm-v0.34.35 to v1.44.1-tm-v0.34.35 is still referenced in test/interchain/go.mod. This needs to be synchronized to maintain consistency across the codebase.
test/interchain/go.mod
still references v1.44.0-tm-v0.34.35
🔗 Analysis chain
LGTM: Clean dependency upgrade to celestia-core v1.44.1-tm-v0.34.35
The replace directive has been correctly updated to point to the new version of celestia-core. This patch version upgrade (v1.44.0 -> v1.44.1) aligns with the PR objectives.
Let's verify the dependency update's consistency and impact:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the dependency update's consistency and potential impact
# Check if there are any other references to the old version
rg "v1\.44\.0-tm-v0\.34\.35"
# Look for any go.sum changes that might be needed
if [ -f "go.sum" ]; then
rg "celestia-core/v1\.44\." go.sum
fi
# Check for any potential breaking changes in the upgrade
gh api repos/celestiaorg/celestia-core/compare/v1.44.0-tm-v0.34.35...v1.44.1-tm-v0.34.35
Length of output: 58637
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge conflict :/
Upgrade to https://github.com/celestiaorg/celestia-core/releases/tag/v1.44.1-tm-v0.34.35 to pick up this fix celestiaorg/celestia-core#1553 (cherry picked from commit 9f3b196)
…4131) (#4139) Upgrade to https://github.com/celestiaorg/celestia-core/releases/tag/v1.44.1-tm-v0.34.35 to pick up this fix https://github.com/celestiaorg/celestia-core/pull/1553<hr>This is an automatic backport of pull request #4131 done by [Mergify](https://mergify.com). Co-authored-by: Rootul P <[email protected]>
Upgrade to https://github.com/celestiaorg/celestia-core/releases/tag/v1.44.1-tm-v0.34.35 to pick up this fix celestiaorg/celestia-core#1553