-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): upgrade to celestia-core v1.44.1-tm-v0.34.35 #4131
Merged
rootulp
merged 2 commits into
celestiaorg:main
from
rootulp:rp/celestia-core-v1.44.1-tm-v0.34.35
Dec 18, 2024
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Dependency update requires attention in test/interchain directory
The dependency update from v1.44.0-tm-v0.34.35 to v1.44.1-tm-v0.34.35 is still referenced in test/interchain/go.mod. This needs to be synchronized to maintain consistency across the codebase.
test/interchain/go.mod
still references v1.44.0-tm-v0.34.35🔗 Analysis chain
LGTM: Clean dependency upgrade to celestia-core v1.44.1-tm-v0.34.35
The replace directive has been correctly updated to point to the new version of celestia-core. This patch version upgrade (v1.44.0 -> v1.44.1) aligns with the PR objectives.
Let's verify the dependency update's consistency and impact:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 58637