chore: define OriginalSquareSize inside generateRandomBlockData

[rootulp]

Spun out of #691

Motivation

While iterating on the TestMerge test, I encountered an unexpected error

            	            	square size is not a power of two: 0

because I failed to declare the square size on the data returned from generateRandomBlockData. I moved a variable definition to avoid this scenario.

Very minor improvement. Can be closed if not helpful.

[codecov-commenter]

Codecov Report

Merging #717 (f12b6db) into main (7bbb270) will increase coverage by 1.69%.
The diff coverage is 64.60%.

@@            Coverage Diff             @@
##             main     #717      +/-   ##
==========================================
+ Coverage   44.52%   46.22%   +1.69%     
==========================================
  Files          32       33       +1     
  Lines        3189     3217      +28     
==========================================
+ Hits         1420     1487      +67     
+ Misses       1666     1619      -47     
- Partials      103      111       +8     

Impacted Files	Coverage Δ
pkg/prove/querier.go	0.00% <0.00%> (ø)
pkg/shares/utils.go	4.08% <0.00%> (+4.08%)	⬆️
pkg/prove/proof.go	82.48% <73.68%> (-1.35%)	⬇️
pkg/shares/split_compact_shares.go	84.00% <77.77%> (+13.59%)	⬆️
pkg/shares/share_merging.go	70.78% <80.00%> (ø)
pkg/shares/split_sparse_shares.go	69.51% <90.00%> (ø)
pkg/da/data_availability_header.go	78.68% <100.00%> (ø)
pkg/shares/parse_compact_shares.go	77.77% <100.00%> (ø)
pkg/shares/parse_sparse_shares.go	88.60% <100.00%> (ø)
pkg/shares/share_splitting.go	60.24% <100.00%> (+46.98%)	⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[evan-forbes]

we can merge even it only fixes tests temporarily, I think I had to do this somewhere else as but forget where.

ideally we calculate the square size, but that's impossible in that package. might have to move it to a specific test package after #692 if we really want to test it.

[evan-forbes]

will investigate this more tmrw

[rootulp]

we can merge even it only fixes tests temporarily

I don't need this change for tests to pass so this is strictly optional and can be closed if undesired

[rootulp]

@evan-forbes do we still want this? If not, I'll close.

[evan-forbes]

no reason not to I don't think

[evan-forbes]

we might have to revert or override the square size if we don't want the max each time, but that's nbd