Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Non-interactive defaults #455

Closed
5 tasks
evan-forbes opened this issue Jul 9, 2021 · 2 comments
Closed
5 tasks

Implement Non-interactive defaults #455

evan-forbes opened this issue Jul 9, 2021 · 2 comments
Assignees

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Jul 9, 2021

Summary

Use the non-interactive defaults described in the spec

Details

The spec describes the non-interactive default rules, which allow for commitments to a message to be generated without external info. Please see spec for more detail.

The app will also need to import this functionality, so that it can properly arrange shares while staying within the max square size.

This issue should only be handled after determining square size #454 has been implemented.

Action Items

  • Add non-default functionality in celestia-core's (probably around message splitting)
  • fix incorrectly generated commitments in the app #53
  • import functionality to celestia-app
  • the app needs to add the starting location of each message as meta data to SignedTransactionDataPayForMessages
  • add non-interactive default psuedo-code to the spec (comment)

blocked by #454

@liamsi
Copy link
Member

liamsi commented Jul 13, 2021

While at it, we should contribute back to the spec to contain these "Non-interactive defaults" as pseudo-code. The current English description is too difficult to follow and predestined for pseudo-code.

@evan-forbes
Copy link
Member Author

closing in favor of celestiaorg/celestia-app#382

Repository owner moved this from TODO to Done in Celestia Node Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants