fix: rpc "no port provided" error by backporting

rpc/jsonrpc/client/http_json_client.go

@@ -9,6 +9,7 @@
 	"net"
 	"net/http"
 	"net/url"
+	"regexp"
 	"strings"
 
 	cmtsync "github.com/tendermint/tendermint/libs/sync"
@@ -24,7 +25,7 @@
 	protoUNIX  = "unix"
 )
 
-//-------------------------------------------------------------
+var endsWithPortPattern = regexp.MustCompile(`:[0-9]+$`)
 
 // Parsed URL structure
 type parsedURL struct {
@@ -87,13 +88,27 @@
 	return strings.ReplaceAll(u.GetHostWithPath(), "/", ".")
 }
 
-// GetDialAddress returns the endpoint to dial for the parsed URL
+// GetDialAddress returns the endpoint to dial for the parsed URL.
 func (u parsedURL) GetDialAddress() string {
-	// if it's not a unix socket we return the host, example: localhost:443
 	if !u.isUnixSocket {
-		return u.Host
-	}
-	// otherwise we return the path of the unix socket, ex /tmp/socket
+		host := u.Host
+		// Check if the host already includes a port
+		_, _, err := net.SplitHostPort(host)
+		if err != nil {
+			// Add the default port based on the scheme
+			switch u.Scheme {
+			case protoHTTP, protoWS:
+				host = net.JoinHostPort(host, "80")
+			case protoHTTPS, protoWSS:
+				host = net.JoinHostPort(host, "443")
+			default:
+				// Handle unsupported schemes explicitly
+				panic("unsupported scheme: " + u.Scheme)
+			}
+		}
+		return host
+	}
+	// For Unix sockets, return the full path
 	return u.GetHostWithPath()
 }
 

rpc/jsonrpc/client/http_json_client_test.go

@@ -44,28 +44,41 @@ func Test_parsedURL(t *testing.T) {
 	}
 
 	tests := map[string]test{
+		"http endpoint": {
+			url:                  "http://example.com",
+			expectedURL:          "http://example.com",
+			expectedHostWithPath: "example.com",
+			expectedDialAddress:  "example.com:80",
+		},
+
+		"http endpoint with port": {
+			url:                  "http://example.com:8080",
+			expectedURL:          "http://example.com:8080",
+			expectedHostWithPath: "example.com:8080",
+			expectedDialAddress:  "example.com:8080",
+		},
 		"unix endpoint": {
 			url:                  "unix:///tmp/test",
 			expectedURL:          "unix://.tmp.test",
 			expectedHostWithPath: "/tmp/test",
 			expectedDialAddress:  "/tmp/test",
 		},
 
-		"http endpoint": {
+		"https endpoint": {
 			url:                  "https://example.com",
 			expectedURL:          "https://example.com",
 			expectedHostWithPath: "example.com",
 			expectedDialAddress:  "example.com",
 		},
 
-		"http endpoint with port": {
+		"https endpoint with port": {
 			url:                  "https://example.com:8080",
 			expectedURL:          "https://example.com:8080",
 			expectedHostWithPath: "example.com:8080",
 			expectedDialAddress:  "example.com:8080",
 		},
 
-		"http path routed endpoint": {
+		"https path routed endpoint": {
 			url:                  "https://example.com:8080/rpc",
 			expectedURL:          "https://example.com:8080/rpc",
 			expectedHostWithPath: "example.com:8080/rpc",