fix: tx search only returning one tx #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninabarbakadze
requested review from
rootulp and
staheri14
and removed request for
a team
ninabarbakadze
commented
Nov 18, 2024
| require.Len(t, results, 3) | ||
|
|
||
| // since two txs were added at height 1 and 2, we should have two unique transactions |
There was a problem hiding this comment.
I added more tests to make sure that transaction searches return unique results and accurate number of transactions included at a specific block height. While this logic is already covered in the unit tests for this file, the existing implementation seems to work correctly in the local repository even without applying the fix.
It was manually tested by me and the NodesGuru team. #1526 (comment)
rootulp
approved these changes
Nov 18, 2024
4 tasks
Magkoooh
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1526