Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate timeout_commit and timeout_propose config #1551

Merged
merged 3 commits into from
Dec 10, 2024
Merged

chore: deprecate timeout_commit and timeout_propose config #1551

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39e2b0b
chore: deprecate timeout_commit and timeout_propose config
rootulp Dec 9, 2024
88f4b34
Update config/toml.go
rootulp Dec 9, 2024
a8747a0
Update config/toml.go
rootulp Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions config/toml.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,8 @@
wal_file = "{{ js .Consensus.WalPath }}"

# How long we wait for a proposal block before prevoting nil
# Deprecated: timeout_commit is overriden by the state machine in app version >= 3.

Check failure on line 483 in config/toml.go

View workflow job for this annotation

GitHub Actions / golangci-lint 

`overriden` is a misspelling of `overridden` (misspell)
rootulp marked this conversation as resolved.
Show resolved Hide resolved
# Therefore, the value set in this config will be ignored.
timeout_propose = "{{ .Consensus.TimeoutPropose }}"
# How much timeout_propose increases with each round
timeout_propose_delta = "{{ .Consensus.TimeoutProposeDelta }}"
Expand All @@ -494,6 +496,8 @@
# How long we wait after committing a block, before starting on the new
# height (this gives us a chance to receive some more precommits, even
# though we already have +2/3).
# Deprecated: timeout_commit is overriden by the state machine in app version >= 3.

Check failure on line 499 in config/toml.go

View workflow job for this annotation

GitHub Actions / golangci-lint 

`overriden` is a misspelling of `overridden` (misspell)
rootulp marked this conversation as resolved.
Show resolved Hide resolved
# Therefore, the value set in this config will be ignored.
timeout_commit = "{{ .Consensus.TimeoutCommit }}"

# How many blocks to look back to check existence of the node's consensus votes before joining consensus
Expand Down
Loading