Update full-consensus-node.mdx #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed command for getting persistent peers.
|
linking this issue, as different formatting in networks repo is causing issues: celestiaorg/networks#350 |
|
thanks for the PR @LavyshAlexander - could you please add the instructions for mac users within the page? |
jcstein
requested changes
Sep 27, 2023
|
yeah, of course, @jcstein. Now instruction with note for mac users ;) |
|
thanks @LavyshAlexander! I think that we should add to the arabica instructions as well, as the formatting of that peers file is the same |
This reverts commit 5635e93.
|
Updated instruction for arabica and some additional formattings. |
jcstein
approved these changes
Oct 4, 2023
thanks again @LavyshAlexander for this PR!
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 Celestia Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
jcstein
added a commit
that referenced
this pull request
Oct 4, 2023
* chore: consolidate consensus nodes into one page * format with prettier * add changes from #1083 * format * match 96a1397 * apply suggestion from #1107 (comment) * feat: interpolate arabica/mocha chain-id * fix: the -> a * Revert "fix: the -> a" This reverts commit d2cea53. * Update docs/nodes/consensus-node.mdx Co-authored-by: Rootul P <[email protected]> * fix: the -> a * Update docs/nodes/consensus-node.mdx Co-authored-by: Rootul P <[email protected]> --------- Co-authored-by: Rootul P <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed command for getting persistent peers.
Overview
Previous version of command for saving persistent peers had bug with removing all new liners from peers list, and as a result node configuration was getting that list in non-readable form:
original list (from here):
original command:
results in:
new command:
results in:
Known issues
Mac users built-in
headcommand does not except negative numbers for-cflag.Solution is to install
coreutilspackage and usegheadcommand from it.and optionally set alias from
headtogheadin shell config (~/.bashrc,~/.zshrcetc):Checklist