Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format of peers.txt changes across testnets #350

Closed
rootulp opened this issue Sep 14, 2023 · 4 comments · Fixed by #523
Closed

Format of peers.txt changes across testnets #350

rootulp opened this issue Sep 14, 2023 · 4 comments · Fixed by #523
Assignees

Comments

@rootulp
Copy link
Collaborator

rootulp commented Sep 14, 2023

Problem

Some scripts downstream of this repo assume that peers.txt has trailing commas. Some scripts assume no trailing commas. Since this repo doesn't enforce a consistent format, it's not clear what scripts should assume.

[email protected]:26656,
daf2cecee2bd7f1b3bf94839f993f807c6b15fbf@celestia-testnet-peer.itrocket.net:11656
contains trailing commas

[email protected]:26656
43e9da043318a4ea0141259c17fcb06ecff816af@rpc-1.celestia.nodes.guru:43656
f9e950870eccdb40e2386896d7b6a7687a103c99@rpc-2.celestia.nodes.guru:43656
does not.

Consequently, I expect a command in the docs https://docs.celestia.org/nodes/full-consensus-node/#setup-the-p2p-networks to fail because

sed -i.bak -e "s/^persistent_peers =./persistent_peers = "$PERSISTENT_PEERS"/" $HOME/.celestia-app/config/config.toml

assumes that there are trailing commas.

Proposal

Describe a format for peers.txt. Enforce it consistently for all peers.txt files. IMO no trailing commas.

@Bidon15
Copy link
Member

Bidon15 commented Sep 19, 2023

Thanks again for the ping, we will take some homework at @celestiaorg/devops to make sure we have rules set and done in linter so folks are following the rules

@jcstein
Copy link
Member

jcstein commented Oct 4, 2023

Due to celestiaorg/docs#1083 - I think it is best we pick one of these options and I will update docs accordingly from there:
(1) leave the standard without commas, implement a linter on this repo to enforce this
(2) make the standard with commas, and implement a linter on this repo that enforces this

@jcstein
Copy link
Member

jcstein commented Oct 11, 2023

note: docs currently have the sed commands set to assume there are no commas in the peers.txt or seeds.txt files

@jcstein
Copy link
Member

jcstein commented Nov 1, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants