-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format of peers.txt
changes across testnets
#350
Comments
Thanks again for the ping, we will take some homework at @celestiaorg/devops to make sure we have rules set and done in linter so folks are following the rules |
Due to celestiaorg/docs#1083 - I think it is best we pick one of these options and I will update docs accordingly from there: |
note: docs currently have the sed commands set to assume there are no commas in the peers.txt or seeds.txt files |
Problem
Some scripts downstream of this repo assume that peers.txt has trailing commas. Some scripts assume no trailing commas. Since this repo doesn't enforce a consistent format, it's not clear what scripts should assume.
networks/mocha-3/peers.txt
Lines 1 to 2 in 3758740
networks/mocha-4/peers.txt
Lines 1 to 3 in 3758740
Consequently, I expect a command in the docs https://docs.celestia.org/nodes/full-consensus-node/#setup-the-p2p-networks to fail because
assumes that there are trailing commas.
Proposal
Describe a format for peers.txt. Enforce it consistently for all peers.txt files. IMO no trailing commas.
The text was updated successfully, but these errors were encountered: