This repository has been archived by the owner on Apr 15, 2024. It is now read-only.
ci: remove the duplicate CI runs #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
approved these changes
Oct 27, 2023
evan-forbes
previously requested changes
Oct 27, 2023
Comment on lines
-6
to
-9
| pull_request: | ||
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
wait why do we want to remove this? won't this get rid of running tests unless manually called?
There was a problem hiding this comment.
perhaps a better question is just where the tests are getting called now?
There was a problem hiding this comment.
they're getting called as part of the ci-release workflow:
orchestrator-relayer/.github/workflows/ci-release.yml
Lines 29 to 34 in 17ffa84
So no need to call them twice
evan-forbes
approved these changes
Nov 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes duplicate CI calls since the setup of go-releaser
Checklist