Skip to content
This repository was archived by the owner on Apr 15, 2024. It is now read-only.

ci: remove the duplicate CI runs #569

Merged
merged 1 commit into from
Nov 2, 2023
Merged

ci: remove the duplicate CI runs #569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@ name: Lint

on:
workflow_call:
pull_request:
push:
branches:
- main

jobs:
markdown-lint:
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ name: Tests / Code Coverage
# This workflow is run on pushes to main & every Pull Requests where a .go, .mod, .sum have been changed
on:
workflow_call:
pull_request:
push:
branches:
- main
Comment on lines -6 to -9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait why do we want to remove this? won't this get rid of running tests unless manually called?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps a better question is just where the tests are getting called now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they're getting called as part of the ci-release workflow:

orchestrator-relayer/.github/workflows/ci-release.yml

Lines 29 to 34 in 17ffa84

jobs:
lint:
uses: ./.github/workflows/lint.yml
test:
uses: ./.github/workflows/test.yml

So no need to call them twice


env:
GO_VERSION: '1.21.1'
Expand Down