Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: support acct_gather.conf #35

Merged
merged 3 commits into from
Dec 3, 2024
Merged

enhancement: support acct_gather.conf #35

merged 3 commits into from
Dec 3, 2024

Conversation

jamesbeedy
Copy link
Contributor

These changes add a data model and editor for acct_gather.conf.

@jamesbeedy jamesbeedy force-pushed the support_acct_gather branch 4 times, most recently from 067a34f to 11730b1 Compare November 25, 2024 15:59
@jamesbeedy
enhancement: support acct_gather.conf
361da6f 
These changes add a data model and editor for acct_gather.conf.
@NucciTheBoss NucciTheBoss self-requested a review November 27, 2024 14:35
NucciTheBoss
NucciTheBoss requested changes Nov 27, 2024
View reviewed changes
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I made some suggestions about manipulating several options in acct_gather.conf using callbacks when parsing and marshaling the file.

slurmutils/models/cgroup.py Outdated Show resolved Hide resolved
slurmutils/editors/acct_gatherconfig.py Outdated Show resolved Hide resolved
slurmutils/models/option.py Outdated Show resolved Hide resolved
slurmutils/models/option.py Outdated Show resolved Hide resolved
slurmutils/models/option.py Outdated Show resolved Hide resolved
slurmutils/models/option.py Outdated Show resolved Hide resolved
tests/unit/editors/test_acct_gatherconfig.py Outdated Show resolved Hide resolved
tests/unit/editors/test_acct_gatherconfig.py Outdated Show resolved Hide resolved
slurmutils/models/option.py Show resolved Hide resolved
NucciTheBoss
NucciTheBoss approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

Thank you for putting together this editor! Will be super clutch to have for setting up InfluxDB. I'll make a follow-on PR that will bump the version of slurmutils and add some docs to the README about the editor 😄

@NucciTheBoss NucciTheBoss merged commit 36b9966 into charmed-hpc:main Dec 3, 2024
3 checks passed
@NucciTheBoss NucciTheBoss mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NucciTheBoss NucciTheBoss NucciTheBoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbeedy @NucciTheBoss