date-fns v3 updates #18

le-cong · 2024-03-20T19:00:04Z

Fixes #15

carlansley

a few things. also, maybe we should resolve the test.ts/mts compilation issue before this goes out?

carlansley · 2024-03-21T17:28:51Z

README.md

+
+### Maintenance notes:
+
+When update the latest code from the original repositories, except making all the necessary changes to make them fully typescript compatible, please remember to carry over the patches to overcoming the following issues:


update -> updating, overcoming -> overcome

carlansley · 2024-03-21T17:29:01Z

README.md

+- spring-forward support
+- nanosecond support
+
+please search for `[PATCH:]` in the existing codebase.


carlansley · 2024-03-21T17:29:57Z

README.md

+
+please search for `[PATCH:]` in the existing codebase.
+
+The date-fns tests files are renamed from `test.ts` to `test.mts` so that they can be excluded from being processed by builder bundling. It's a workaround until better approach is available to have a unified control over both regular compilation and bundling.


...until a better approach is available to have unified control...

carlansley · 2024-03-21T17:31:28Z

src/date-fns/_lib/format/longFormatters/index.ts

-    case 'PPP':
-      return formatLong.date({ width: 'long' });
-    case 'PPPP':
+    case "P":


should we apply our prettier formatting? most of the changes in this file are just formatting changes

le-cong · 2024-03-21T19:12:20Z

a few things. also, maybe we should resolve the test.ts/mts compilation issue before this goes out?

my reason for not doing type checking for date-fns's tests are:

it's 3rd party source code and the typing errors are massive, it's both complex and time consuming if not impossible.
we do run all those tests using vitest to make sure that everything essentially works.

what do you think?

ramaghanta

lgtm

github-actions · 2024-03-22T19:18:35Z

Coverage after merging date-fns-v3 into main will be

59.19%	▾ -1.44%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
format-utc.ts	100%	100%	100%	100%
index.ts	100%	100%	100%	100%
instant.ts	100%	100%	100%	100%
now.ts	100%	100%	100%	100%
temporal.ts	100%	100%	100%	100%
src/date-fns
index.ts	100%	100%	100%	100%
types.ts	0%	0%	0%	0%	1, 1, 10, 100–109, 11, 110–119, 12, 120–129, 13, 130–139, 14, 140–149, 15, 150–159, 16, 160–169, 17, 170–179, 18, 180–189, 19, 190–199, 2, 20, 200–209, 21, 210–219, 22, 220–229, 23, 230–239, 24, 240–249, 25, 250–259, 26, 260–269, 27, 270–279, 28, 280–289, 29, 290–299, 3, 30, 300–303, 31–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–99
src/date-fns-tz
index.ts	100%	100%	100%	100%
types.ts	0%	0%	0%	0%	1, 1, 10–14, 2–9
src/date-fns-tz/_lib/newDateUTC
index.ts	100%	100%	100%	100%
src/date-fns-tz/_lib/tzIntlTimeZoneName
index.ts	26.09%	100%	0%	27.91%	10–15, 17–25, 29–43, 9
src/date-fns-tz/_lib/tzParseTimezone
index.ts	52.38%	37.50%	50%	54.11%	101, 105–130, 132–134, 143–145, 20–22, 26–28, 34–42, 46–56, 60–61, 65, 69, 69–71, 73–83
src/date-fns-tz/_lib/tzPattern
index.ts	100%	100%	100%	100%
src/date-fns-tz/_lib/tzTokenizeDate
index.ts	82.42%	75%	100%	82.50%	30–35, 58–67
src/date-fns-tz/date-fns-v2-lib/assign
index.ts	7.14%	100%	0%	7.69%	10–13, 2–9
src/date-fns-tz/date-fns-v2-lib/cloneObject
index.ts	50%	100%	0%	60%	4–5
src/date-fns-tz/format
index.ts	96.90%	50%	100%	97.70%	324, 335, 335–343
src/date-fns-tz/format/formatters
index.ts	16.57%	100%	0%	17.47%	10, 100–109, 11, 110–114, 118–119, 12, 120–126, 128–129, 13, 130–135, 137–139, 14, 140–144, 146–149, 15, 150–152, 154–159, 16, 160–164, 17–39, 44–70, 75–89, 9, 90–92, 97–99
src/date-fns-tz/formatInTimeZone
index.ts	73.68%	100%	0%	75.68%	29–37
src/date-fns-tz/getTimezoneOffset
index.ts	90.91%	100%	0%	93.75%	31–32
src/date-fns-tz/toDate
index.ts	25.92%	20%	9.09%	26.47%	103–104, 108–153, 156–186, 188–218, 220–308, 310–356, 358–367, 374–376, 378–398, 400–414, 416–426, 428–442, 86–88, 90–92, 96–97, 97, 97–99
src/date-fns-tz/utcToZonedTime
index.ts	100%	100%	100%	100%
src/date-fns-tz/zonedTimeToUtc
index.ts	58.18%	100%	0%	59.26%	33–54
src/date-fns/_lib/addLeadingZeros
index.ts	87.50%	50%	100%	100%	2
src/date-fns/_lib/defaultLocale
index.ts	100%	100%	100%	100%
src/date-fns/_lib/defaultOptions
index.ts	81.25%	100%	50%	84.62%	12–13
src/date-fns/_lib/format/formatters
index.ts	32.63%	40%	22.22%	32.91%	100, 106–111, 118–134, 139–142, 155–156, 161–191, 196–226, 233, 237–238, 240–244, 246–250, 252–254, 260–287, 292–298, 303–309, 314–316, 323–329, 334–363, 368–404, 409–445, 450–487, 492–520, 525–560, 565–596, 601–605, 612–614, 621–627, 632–639, 644–646, 653–655, 667–692, 697–718, 723–735, 740–752, 757–758, 763–764, 768–777, 779–785, 787–793, 86–99
src/date-fns/_lib/format/lightFormatters
index.ts	80.33%	57.14%	88.89%	82.83%	30–31, 37, 47–63, 69, 69, 77
src/date-fns/_lib/format/longFormatters
index.ts	19.72%	100%	0%	20.59%	10–17, 20–31, 34–59, 6, 60–63, 7–9
src/date-fns/_lib/getRoundingMethod
index.ts	27.27%	100%	0%	30%	10, 4–9
src/date-fns/_lib/getTimezoneOffsetInMilliseconds
index.ts	46.67%	100%	0%	48.28%	15–29
src/date-fns/_lib/protectedTokens
index.ts	65.52%	100%	50%	65.22%	15–18, 20–23
src/date-fns/_lib/test
index.ts	0%	0%	0%	0%	1, 1, 10–19, 2, 20–29, 3–9
src/date-fns/_test/dst
tzOffsetTransitions.ts	0%	0%	0%	0%	1, 1, 10, 100–109, 11, 110–119, 12, 120–129, 13, 130–139, 14, 140, 15–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–99
src/date-fns/_test/dst/addBusinessDays
basic.ts	0%	0%	0%	0%	1, 1, 10–17, 2–9
src/date-fns/_test/dst/eachDayOfInterval
basic.ts	0%	0%	0%	0%	1, 1, 10–19, 2, 20–21, 3–9
src/date-fns/_test/dst/formatDistanceStrict
cairo.ts	0%	0%	0%	0%	1, 1–8
melbourne.ts	0%	0%	0%	0%	1, 1, 10–12, 2–9
src/date-fns/_test/dst/getOverlappingDaysInIntervals
basic.ts	0%	0%	0%	0%	1, 1, 10–16, 2–9
src/date-fns/_test/dst/parseISO
basic.ts	0%	0%	0%	0%	1, 1, 10–19, 2, 20–23, 3–9
samoa.ts	0%	0%	0%	0%	1, 1, 10–12, 2–9
sydney.ts	0%	0%	0%	0%	1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–57, 6–9
src/date-fns/_test/formatISO
india.ts	0%	0%	0%	0%	1, 1–9
src/date-fns/_test/formatRFC3339
australia.ts	0%	0%	0%	0%	1, 1, 10–19, 2, 20, 3–9
india.ts	0%	0%	0%	0%	1, 1, 10–19, 2, 20, 3–9
newfoundland.ts	0%	0%	0%	0%	1, 1, 10–19, 2, 20–21, 3–9
newzealand.ts	0%	0%	0%	0%	1, 1, 10–19, 2, 20–21, 3–9
poland.ts	0%	0%	0%	0%	1, 1, 10–19, 2, 20, 3–9
src/date-fns/add
index.ts	94.29%	20%	100%	100%	52, 52, 55, 55
src/date-fns/addBusinessDays
index.ts	42.86%	100%	0%	43.55%	28–62
src/date-fns/addDays
index.ts	86.49%	33.33%	100%	90.91%	26–30
src/date-fns/addHours
index.ts	88.89%	100%	0%	92.31%	25–26
src/date-fns/addISOWeekYears
index.ts	89.66%	100%	0%	92.86%	27–28
src/date-fns/addMilliseconds
index.ts	85.71%	100%	0%	88.89%	25–27
src/date-fns/addMinutes
index.ts	88.89%	100%	0%	92.31%	25–26
src/date-fns/addMonths
index.ts	86.76%	25%	100%	90.48%	30–34, 48–51
src/date-fns/addQuarters
index.ts	85.19%	100%	0%	88.46%	24–26
src/date-fns/addSeconds
index.ts	88.46%	100%	0%	92%	24–25
src/date-fns/addWeeks

github-actions · 2024-03-22T19:19:13Z

Beta Published - Install Command: npm install @checkdigit/[email protected]

github-actions · 2024-03-26T20:19:18Z

✅ PR review status - All reviews completed and approved!

le-cong added 6 commits March 19, 2024 15:14

v3 and compile

164b50c

v3 and compile

203b911

can run test (with error)

f296241

apply hack, pass tests

197ffdb

enable date-fns tests, README

aa89528

update CI config file

232efd9

le-cong added the MAJOR label Mar 20, 2024

le-cong self-assigned this Mar 20, 2024

workaround to exclude date-fns tests from being processed by bundler

8f33432

le-cong requested review from carlansley and ramaghanta March 20, 2024 20:03

carlansley requested changes Mar 21, 2024

View reviewed changes

address carl's comments

b919b0e

le-cong requested a review from carlansley March 21, 2024 19:20

remove date-fns tests and cleanup related configurations

72a35f9

ramaghanta approved these changes Mar 22, 2024

View reviewed changes

update README and dependencies

39350b8

carlansley approved these changes Mar 26, 2024

View reviewed changes

le-cong merged commit 0c7bbd8 into main Mar 26, 2024
9 checks passed

le-cong deleted the date-fns-v3 branch March 26, 2024 21:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

date-fns v3 updates #18

date-fns v3 updates #18

le-cong commented Mar 20, 2024 •

edited

Loading

carlansley left a comment

carlansley Mar 21, 2024

carlansley Mar 21, 2024

carlansley Mar 21, 2024

carlansley Mar 21, 2024

le-cong commented Mar 21, 2024

ramaghanta left a comment

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 26, 2024


		### Maintenance notes:

		When update the latest code from the original repositories, except making all the necessary changes to make them fully typescript compatible, please remember to carry over the patches to overcoming the following issues:


		please search for `[PATCH:]` in the existing codebase.

		The date-fns tests files are renamed from `test.ts` to `test.mts` so that they can be excluded from being processed by builder bundling. It's a workaround until better approach is available to have a unified control over both regular compilation and bundling.

date-fns v3 updates #18

date-fns v3 updates #18

Conversation

le-cong commented Mar 20, 2024 • edited Loading

carlansley left a comment

Choose a reason for hiding this comment

carlansley Mar 21, 2024

Choose a reason for hiding this comment

carlansley Mar 21, 2024

Choose a reason for hiding this comment

carlansley Mar 21, 2024

Choose a reason for hiding this comment

carlansley Mar 21, 2024

Choose a reason for hiding this comment

le-cong commented Mar 21, 2024

ramaghanta left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 26, 2024

le-cong commented Mar 20, 2024 •

edited

Loading