-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
date-fns v3 updates #18
Merged
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
164b50c
v3 and compile
le-cong 203b911
v3 and compile
le-cong f296241
can run test (with error)
le-cong 197ffdb
apply hack, pass tests
le-cong aa89528
enable date-fns tests, README
le-cong 232efd9
update CI config file
le-cong 8f33432
workaround to exclude date-fns tests from being processed by bundler
le-cong b919b0e
address carl's comments
le-cong 72a35f9
remove date-fns tests and cleanup related configurations
le-cong 39350b8
update README and dependencies
le-cong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,10 +17,10 @@ and date manipulation functions provided by date-fns. Features: | |
Temporal (vs the millisecond precision of standard Date built-in) is useful for webservices recording the time of events, where concurrent activity may occur and millisecond precision does not provide adequate uniqueness and ordering. | ||
|
||
The [`date-fns`](https://date-fns.org) library is included. The only locale currently supported is `en-US`, but otherwise contains all | ||
available functionality as of v2.29.1. | ||
available functionality as of v3.6.0. | ||
|
||
Additionally, the [`date-fns-tz`](https://github.com/marnusw/date-fns-tz) library is included. Contains all | ||
available functionality as of v1.3.7. | ||
available functionality as of v1.3.7 except fp. | ||
|
||
### `formatUtc` | ||
|
||
|
@@ -76,3 +76,14 @@ The reference documentation is here: https://tc39.es/proposal-temporal/docs/ | |
The documentation for `date-fns` is here: https://date-fns.org/ | ||
|
||
The documentation for `date-fns-tz` is here: https://github.com/marnusw/date-fns-tz | ||
|
||
### Maintenance notes: | ||
|
||
When update the latest code from the original repositories, except making all the necessary changes to make them fully typescript compatible, please remember to carry over the patches to overcoming the following issues: | ||
|
||
- spring-forward support | ||
- nanosecond support | ||
|
||
please search for `[PATCH:]` in the existing codebase. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. capital P |
||
|
||
The date-fns tests files are renamed from `test.ts` to `test.mts` so that they can be excluded from being processed by builder bundling. It's a workaround until better approach is available to have a unified control over both regular compilation and bundling. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ...until a better approach is available to have unified control... |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update -> updating, overcoming -> overcome