Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add yosys-plugins #645

Draft
wants to merge 1,114 commits into
base: main
Choose a base branch
from
Draft

add yosys-plugins #645

wants to merge 1,114 commits into from

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Oct 3, 2022

This PR moves the content of chipsalliance/yosys-f4pga-plugins to this repo as subdir yosys-plugins.

lpawelcz and others added 30 commits March 8, 2022 15:26
…-tdp-inference

ql-qlf: qlf_k6n10f: add TDP_BRAM36 inference
Equivalence checks for qlf_k6n10f DSP tests
Added installation of k6n10f simulation models that were missing
This works as an alias to 'read_verilog_with_uhdm'

Signed-off-by: Tomasz Gorochowik <[email protected]>
…orce-parse

Force -parse flag for Surelog when reading Verilog directly
mkurc-ant and others added 17 commits July 29, 2022 12:10
Signed-off-by: Maciej Kurc <[email protected]>
The code for handling unions has been added together with the code for
structs, however it was never called due to a missing switch entry.

Signed-off-by: Tomasz Gorochowik <[email protected]>
…cal-empty-string-test

Use a canonical way to test for an empty string.
…-asymmetric-ram

ql-qlf: k6n10f: add asymmetric RAM inference
…bram-inference

Fix QuickLogic asymmetric BRAM inference
Instead of `which`, the suggested alternative
is `command -v`

Signed-off-by: Henner Zeller <[email protected]>
Signed-off-by: Unai Martinez-Corral <[email protected]>
@umarcor umarcor added Dependencies Pull requests that update a dependency file CI: Github Actions Continuous Integration issues related to GitHub Actions (Windows, Linux and MacOS) labels Oct 3, 2022
@mithro
Copy link
Contributor

mithro commented Oct 3, 2022

Why?

@umarcor umarcor marked this pull request as draft October 3, 2022 15:50
@umarcor
Copy link
Contributor Author

umarcor commented Oct 3, 2022

@mithro to reduce the maintenance burden (CI, docs, etc.) and to reduce the fragmentation in the community (less experienced users not knowing where to report issues -f4pga, examples, plugins, conda, tools-). Nevertheless, this is likely to be kept on hold for a long time.

@kboronski-ant kboronski-ant self-assigned this Oct 4, 2022
@kboronski-ant
Copy link
Collaborator

kboronski-ant commented Oct 4, 2022

This is over 78k lines of code, which is way more than all the code we have here at the moment.

I'm all for unification of tools used in our toolchain under the f4pga python tool, but for now I think this might be a step too far, especially given that the yosys plugins are a standalone thing now and I think it makes sense to keep them that way. That being said, I don't know what every single one does. SystemVerilog parser is a plugin that a has a very general usage, that's not necessarily tied to f4pga flow, but maybe there's something else that is very specific to f4pga flow. I can't tell at the moment, but maybe in that case a better approach would be to bring those individual plugins that are very specific to our flow, here in separate PRs.

@kboronski-ant kboronski-ant removed their assignment Oct 4, 2022
@umarcor
Copy link
Contributor Author

umarcor commented Oct 4, 2022

@kboronski-ant, this PR is unrelated to the f4pga python tool. The reasoning is simpler:

  • This repo: "is the top-level repository for the F4PGA project".
  • yosys-f4pga-plugins, as the name implies and as stated in the description: "plugins for Yosys developed as part of the F4PGA project".

Both the f4pga python tool and the plugins can be installed and used without cloning the repos, hence having them in the same location produces no conflict from a usage perspective.
The main point is to have Sphinx documentation for plugins without creating and maintaining another site, and to ease having the CI updated by reducing the number of workflows to maintain.

Nonetheless, as commented, this is to be kept on hold for a long time, because several other pending tasks need to be solved first.

@mithro
Copy link
Contributor

mithro commented Oct 4, 2022

@umarcor - See chipsalliance/yosys-f4pga-plugins#312 -- we have been meaning to rename the repository because these they are not only useful for f4pga but ASIC people too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backlog CI: Github Actions Continuous Integration issues related to GitHub Actions (Windows, Linux and MacOS) Dependencies Pull requests that update a dependency file Discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.