Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: add push_logs() to log interface #3576

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Jan 28, 2025

Description of changes

Does what it says on the tin.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

n/a

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

codetheweb commented Jan 28, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codetheweb codetheweb force-pushed the feat-log-interface-push-logs branch from a9ccc20 to e5b3a38 Compare January 28, 2025 18:43
@codetheweb codetheweb marked this pull request as ready for review January 28, 2025 18:45
@codetheweb codetheweb force-pushed the feat-log-interface-push-logs branch from e5b3a38 to 0d7ffbc Compare January 28, 2025 22:27
@codetheweb codetheweb force-pushed the feat-log-interface-push-logs branch from 0d7ffbc to eff727f Compare January 28, 2025 22:42
@codetheweb codetheweb force-pushed the feat-log-interface-push-logs branch from eff727f to 206fb61 Compare January 28, 2025 23:07
Copy link
Contributor Author

codetheweb commented Jan 29, 2025

Merge activity

  • Jan 28, 7:36 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 28, 7:39 PM EST: Graphite rebased this pull request as part of a merge.
  • Jan 28, 8:26 PM EST: A user merged this pull request with Graphite.

@codetheweb codetheweb changed the base branch from cln-split-log-impls to graphite-base/3576 January 29, 2025 00:36
@codetheweb codetheweb changed the base branch from graphite-base/3576 to main January 29, 2025 00:37
@codetheweb codetheweb force-pushed the feat-log-interface-push-logs branch from 206fb61 to 7067047 Compare January 29, 2025 00:38
@codetheweb codetheweb merged commit 6b8d00d into main Jan 29, 2025
91 checks passed
@codetheweb codetheweb deleted the feat-log-interface-push-logs branch January 29, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants