[ENH]: add Rust SQLite impl of log #3577
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
codetheweb
force-pushed
the
feat-sqlite-log
branch
from
5908925 to
03ce145
Compare
codetheweb
force-pushed
the
feat-log-interface-push-logs
branch
from
a9ccc20 to
e5b3a38
Compare
codetheweb
force-pushed
the
feat-sqlite-log
branch
from
03ce145 to
967bc92
Compare
codetheweb
force-pushed
the
feat-log-interface-push-logs
branch
from
e5b3a38 to
0d7ffbc
Compare
1 task
codetheweb
force-pushed
the
feat-log-interface-push-logs
branch
from
0d7ffbc to
eff727f
Compare
codetheweb
force-pushed
the
feat-sqlite-log
branch
from
967bc92 to
46373db
Compare
codetheweb
force-pushed
the
feat-log-interface-push-logs
branch
from
eff727f to
206fb61
Compare
codetheweb
force-pushed
the
feat-sqlite-log
branch
from
46373db to
3c3c539
Compare
rescrv
reviewed
Jan 28, 2025
| InvalidEmbedding(bytemuck::PodCastError), | ||
| #[error("Failed to parse metadata: {0}")] | ||
| InvalidMetadata(#[from] serde_json::Error), | ||
| } |
There was a problem hiding this comment.
Do we want to embed types like bytemuck, sqlx, and serde_json? They aren't serializable. Errors might be nice to have go across the network.
There was a problem hiding this comment.
thought about this a bit more and I'm not sure how applicable this is since many of our current errors aren't serializable either
however they all have .to_string() which is trivial to serialize
codetheweb
force-pushed
the
feat-sqlite-log
branch
3 times, most recently
from
48d298e to
86bb7d3
Compare
codetheweb
changed the base branch from
feat-log-interface-push-logs
to
graphite-base/3577
codetheweb
force-pushed
the
feat-sqlite-log
branch
4 times, most recently
from
5406e83 to
0b5f332
Compare
codetheweb
force-pushed
the
feat-sqlite-log
branch
from
0b5f332 to
57a736b
Compare
codetheweb
commented
Jan 29, 2025
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { |
There was a problem hiding this comment.
todo: need to fix tests once we can run migrations from Rust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?